From: Kalle Valo <kvalo@codeaurora.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/7] wlcore: avoid fragile snprintf use
Date: Wed, 09 Mar 2016 13:49:12 +0200 [thread overview]
Message-ID: <8760wvswg7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1457469654-17059-6-git-send-email-linux@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Tue, 8 Mar 2016 21:40:52 +0100")
Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:
> Appending to a buffer like this is not guaranteed to work (passing
> overlapping src and dst buffers to snprintf is undefined
> behaviour). The standard and safe idiom is to keep track of the
> current string length.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Should I take this or what's the plan?
--
Kalle Valo
next prev parent reply other threads:[~2016-03-09 11:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-05 20:38 snprintf, overlapping destination and source Rasmus Villemoes
2015-12-05 20:42 ` Julia Lawall
2015-12-07 22:04 ` Kees Cook
2015-12-16 13:14 ` Rasmus Villemoes
2016-03-08 20:40 ` [RFC 0/7] eliminate snprintf with overlapping src and dst Rasmus Villemoes
2016-03-08 20:40 ` [RFC 1/7] drm/amdkfd: avoid fragile and inefficient snprintf use Rasmus Villemoes
2016-03-14 14:33 ` Oded Gabbay
2016-03-14 19:18 ` Rasmus Villemoes
2016-03-08 20:40 ` [RFC 2/7] Input: joystick - avoid fragile " Rasmus Villemoes
2016-03-09 6:49 ` Andy Shevchenko
2016-03-08 20:40 ` [RFC 3/7] leds: avoid fragile sprintf use Rasmus Villemoes
2016-03-08 20:40 ` [RFC 4/7] drivers/media/pci/zoran: avoid fragile snprintf use Rasmus Villemoes
2016-03-08 20:40 ` [RFC 5/7] wlcore: " Rasmus Villemoes
2016-03-09 11:49 ` Kalle Valo [this message]
2016-03-08 20:40 ` [RFC 6/7] [media] ati_remote: " Rasmus Villemoes
2016-03-08 20:40 ` [RFC 7/7] USB: usbatm: avoid fragile and inefficient " Rasmus Villemoes
2016-03-08 21:01 ` Joe Perches
2016-03-10 23:56 ` Greg Kroah-Hartman
2016-03-09 13:08 ` Sergei Shtylyov
2016-03-08 23:07 ` [RFC 0/7] eliminate snprintf with overlapping src and dst Kees Cook
2016-03-08 23:13 ` Kees Cook
2016-03-09 6:51 ` Andy Shevchenko
2016-03-09 20:49 ` Andrew Morton
2016-03-09 22:19 ` Rasmus Villemoes
2016-03-10 13:59 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760wvswg7.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).