From: Rusty Russell <rusty@rustcorp.com.au>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Dave Jones <davej@codemonkey.org.uk>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH] module: do not print allocation-fail warning on bogus user buffer size
Date: Tue, 17 Feb 2015 10:25:48 +1030 [thread overview]
Message-ID: <8761b1tnqz.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1424085783-200431-1-git-send-email-kirill.shutemov@linux.intel.com>
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
> init_module(2) passes user-specified buffer length directly to
> vmalloc(). It makes warn_alloc_failed() to print out a lot of info into
> dmesg if user specified insane size, like -1.
>
> Let's silence the warning. It doesn't add much value to -ENOMEM return
> code. Without the patch the syscall is prohibitive noisy for testing
> with trinity.
Heh, we used to have an explicit length check because vmalloc would
BUG(). So I guess this is progress...
Applied thanks,
Rusty.
prev parent reply other threads:[~2015-02-16 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 11:23 [PATCH] module: do not print allocation-fail warning on bogus user buffer size Kirill A. Shutemov
2015-02-16 23:55 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761b1tnqz.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davej@codemonkey.org.uk \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).