* [PATCH -next] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data"
@ 2019-01-29 8:03 YueHaibing
2019-02-15 20:14 ` Robert Jarzmik
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-01-29 8:03 UTC (permalink / raw)
To: linux, daniel, robert.jarzmik; +Cc: linux-kernel, linux-arm-kernel, YueHaibing
Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
kfree, iounmap, clk_put etc no need do any more in remove path.
Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/arm/plat-pxa/ssp.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index ed36dca..bf25f78 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -183,25 +183,16 @@ static int pxa_ssp_probe(struct platform_device *pdev)
static int pxa_ssp_remove(struct platform_device *pdev)
{
- struct resource *res;
struct ssp_device *ssp;
ssp = platform_get_drvdata(pdev);
if (ssp == NULL)
return -ENODEV;
- iounmap(ssp->mmio_base);
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- release_mem_region(res->start, resource_size(res));
-
- clk_put(ssp->clk);
-
mutex_lock(&ssp_lock);
list_del(&ssp->node);
mutex_unlock(&ssp_lock);
- kfree(ssp);
return 0;
}
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data"
2019-01-29 8:03 [PATCH -next] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data" YueHaibing
@ 2019-02-15 20:14 ` Robert Jarzmik
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2019-02-15 20:14 UTC (permalink / raw)
To: YueHaibing; +Cc: linux, daniel, linux-kernel, linux-arm-kernel
YueHaibing <yuehaibing@huawei.com> writes:
> Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
> kfree, iounmap, clk_put etc no need do any more in remove path.
>
> Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Sorry for the late reply, I had forgotten to answer.
Queued to pxa/for-next with a small spelling fix in the commit message, thanks.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-15 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 8:03 [PATCH -next] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data" YueHaibing
2019-02-15 20:14 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).