* [PATCH net] net: mvpp2: 10G modes aren't supported on all ports
@ 2018-12-11 16:32 Antoine Tenart
2018-12-11 16:36 ` Russell King - ARM Linux
2018-12-18 22:49 ` David Miller
0 siblings, 2 replies; 10+ messages in thread
From: Antoine Tenart @ 2018-12-11 16:32 UTC (permalink / raw)
To: davem, linux
Cc: Antoine Tenart, netdev, linux-kernel, thomas.petazzoni,
maxime.chevallier, gregory.clement, miquel.raynal, nadavh,
stefanc, ymarkman, mw, Baruch Siach
The mvpp2_phylink_validate() function sets all modes that are
supported by a given PPv2 port. A recent change made all ports to
advertise they support 10G modes in certain cases. This is not true,
as only the port #0 can do so. This patch fixes it.
Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules")
Cc: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 125ea99418df..88aa488054a8 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -4405,12 +4405,14 @@ static void mvpp2_phylink_validate(struct net_device *dev,
case PHY_INTERFACE_MODE_10GKR:
case PHY_INTERFACE_MODE_XAUI:
case PHY_INTERFACE_MODE_NA:
- phylink_set(mask, 10000baseCR_Full);
- phylink_set(mask, 10000baseSR_Full);
- phylink_set(mask, 10000baseLR_Full);
- phylink_set(mask, 10000baseLRM_Full);
- phylink_set(mask, 10000baseER_Full);
- phylink_set(mask, 10000baseKR_Full);
+ if (port->gop_id == 0) {
+ phylink_set(mask, 10000baseCR_Full);
+ phylink_set(mask, 10000baseSR_Full);
+ phylink_set(mask, 10000baseLR_Full);
+ phylink_set(mask, 10000baseLRM_Full);
+ phylink_set(mask, 10000baseER_Full);
+ phylink_set(mask, 10000baseKR_Full);
+ }
/* Fall-through */
case PHY_INTERFACE_MODE_RGMII:
case PHY_INTERFACE_MODE_RGMII_ID:
--
2.19.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-11 16:32 [PATCH net] net: mvpp2: 10G modes aren't supported on all ports Antoine Tenart @ 2018-12-11 16:36 ` Russell King - ARM Linux 2018-12-11 17:53 ` Baruch Siach 2018-12-11 21:11 ` Stefan Chulski 2018-12-18 22:49 ` David Miller 1 sibling, 2 replies; 10+ messages in thread From: Russell King - ARM Linux @ 2018-12-11 16:36 UTC (permalink / raw) To: Antoine Tenart Cc: davem, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, nadavh, stefanc, ymarkman, mw, Baruch Siach On Tue, Dec 11, 2018 at 05:32:28PM +0100, Antoine Tenart wrote: > The mvpp2_phylink_validate() function sets all modes that are > supported by a given PPv2 port. A recent change made all ports to > advertise they support 10G modes in certain cases. This is not true, > as only the port #0 can do so. This patch fixes it. > > Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules") > Cc: Baruch Siach <baruch@tkos.co.il> > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 125ea99418df..88aa488054a8 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -4405,12 +4405,14 @@ static void mvpp2_phylink_validate(struct net_device *dev, > case PHY_INTERFACE_MODE_10GKR: > case PHY_INTERFACE_MODE_XAUI: Are these modes supported on anything except port 0? If not, you should be rejecting these, rather than just treating them as RGMII. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-11 16:36 ` Russell King - ARM Linux @ 2018-12-11 17:53 ` Baruch Siach 2018-12-11 18:51 ` Russell King - ARM Linux 2018-12-11 21:11 ` Stefan Chulski 1 sibling, 1 reply; 10+ messages in thread From: Baruch Siach @ 2018-12-11 17:53 UTC (permalink / raw) To: Russell King - ARM Linux Cc: Antoine Tenart, davem, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, nadavh, stefanc, ymarkman, mw Hi Russell, Antoine, Russell King - ARM Linux writes: > On Tue, Dec 11, 2018 at 05:32:28PM +0100, Antoine Tenart wrote: >> The mvpp2_phylink_validate() function sets all modes that are >> supported by a given PPv2 port. A recent change made all ports to >> advertise they support 10G modes in certain cases. This is not true, >> as only the port #0 can do so. This patch fixes it. >> >> Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules") >> Cc: Baruch Siach <baruch@tkos.co.il> >> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> >> --- >> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 ++++++++------ >> 1 file changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >> index 125ea99418df..88aa488054a8 100644 >> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >> @@ -4405,12 +4405,14 @@ static void mvpp2_phylink_validate(struct net_device *dev, >> case PHY_INTERFACE_MODE_10GKR: >> case PHY_INTERFACE_MODE_XAUI: > > Are these modes supported on anything except port 0? If not, you > should be rejecting these, rather than just treating them as RGMII. That is, something like this, right? diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index 125ea99418df..04cb0241ca2b 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -4404,13 +4404,18 @@ static void mvpp2_phylink_validate(struct net_device *dev, switch (state->interface) { case PHY_INTERFACE_MODE_10GKR: case PHY_INTERFACE_MODE_XAUI: + if (port->gop_id != 0) + goto empty_set; + /* Fall-through */ case PHY_INTERFACE_MODE_NA: - phylink_set(mask, 10000baseCR_Full); - phylink_set(mask, 10000baseSR_Full); - phylink_set(mask, 10000baseLR_Full); - phylink_set(mask, 10000baseLRM_Full); - phylink_set(mask, 10000baseER_Full); - phylink_set(mask, 10000baseKR_Full); + if (port->gop_id == 0) { + phylink_set(mask, 10000baseCR_Full); + phylink_set(mask, 10000baseSR_Full); + phylink_set(mask, 10000baseLR_Full); + phylink_set(mask, 10000baseLRM_Full); + phylink_set(mask, 10000baseER_Full); + phylink_set(mask, 10000baseKR_Full); + } /* Fall-through */ case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII_ID: baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-11 17:53 ` Baruch Siach @ 2018-12-11 18:51 ` Russell King - ARM Linux 2018-12-12 9:30 ` Antoine Tenart 0 siblings, 1 reply; 10+ messages in thread From: Russell King - ARM Linux @ 2018-12-11 18:51 UTC (permalink / raw) To: Baruch Siach Cc: Antoine Tenart, davem, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, nadavh, stefanc, ymarkman, mw On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > That is, something like this, right? > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 125ea99418df..04cb0241ca2b 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -4404,13 +4404,18 @@ static void mvpp2_phylink_validate(struct net_device *dev, > switch (state->interface) { > case PHY_INTERFACE_MODE_10GKR: > case PHY_INTERFACE_MODE_XAUI: > + if (port->gop_id != 0) > + goto empty_set; > + /* Fall-through */ > case PHY_INTERFACE_MODE_NA: > - phylink_set(mask, 10000baseCR_Full); > - phylink_set(mask, 10000baseSR_Full); > - phylink_set(mask, 10000baseLR_Full); > - phylink_set(mask, 10000baseLRM_Full); > - phylink_set(mask, 10000baseER_Full); > - phylink_set(mask, 10000baseKR_Full); > + if (port->gop_id == 0) { > + phylink_set(mask, 10000baseCR_Full); > + phylink_set(mask, 10000baseSR_Full); > + phylink_set(mask, 10000baseLR_Full); > + phylink_set(mask, 10000baseLRM_Full); > + phylink_set(mask, 10000baseER_Full); > + phylink_set(mask, 10000baseKR_Full); > + } > /* Fall-through */ > case PHY_INTERFACE_MODE_RGMII: > case PHY_INTERFACE_MODE_RGMII_ID: > Yep, looks fine to me, thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-11 18:51 ` Russell King - ARM Linux @ 2018-12-12 9:30 ` Antoine Tenart 2018-12-12 14:14 ` Antoine Tenart 0 siblings, 1 reply; 10+ messages in thread From: Antoine Tenart @ 2018-12-12 9:30 UTC (permalink / raw) To: Russell King - ARM Linux Cc: Baruch Siach, Antoine Tenart, davem, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, nadavh, stefanc, ymarkman, mw Hi Russell, Baruch, On Tue, Dec 11, 2018 at 06:51:56PM +0000, Russell King - ARM Linux wrote: > On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > > That is, something like this, right? > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > index 125ea99418df..04cb0241ca2b 100644 > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > @@ -4404,13 +4404,18 @@ static void mvpp2_phylink_validate(struct net_device *dev, > > switch (state->interface) { > > case PHY_INTERFACE_MODE_10GKR: > > case PHY_INTERFACE_MODE_XAUI: > > + if (port->gop_id != 0) > > + goto empty_set; > > + /* Fall-through */ > > case PHY_INTERFACE_MODE_NA: > > - phylink_set(mask, 10000baseCR_Full); > > - phylink_set(mask, 10000baseSR_Full); > > - phylink_set(mask, 10000baseLR_Full); > > - phylink_set(mask, 10000baseLRM_Full); > > - phylink_set(mask, 10000baseER_Full); > > - phylink_set(mask, 10000baseKR_Full); > > + if (port->gop_id == 0) { > > + phylink_set(mask, 10000baseCR_Full); > > + phylink_set(mask, 10000baseSR_Full); > > + phylink_set(mask, 10000baseLR_Full); > > + phylink_set(mask, 10000baseLRM_Full); > > + phylink_set(mask, 10000baseER_Full); > > + phylink_set(mask, 10000baseKR_Full); > > + } > > /* Fall-through */ > > case PHY_INTERFACE_MODE_RGMII: > > case PHY_INTERFACE_MODE_RGMII_ID: > > > > Yep, looks fine to me, thanks. This looks good, thanks! I'll send a v2. Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-12 9:30 ` Antoine Tenart @ 2018-12-12 14:14 ` Antoine Tenart 2018-12-12 14:36 ` Baruch Siach 0 siblings, 1 reply; 10+ messages in thread From: Antoine Tenart @ 2018-12-12 14:14 UTC (permalink / raw) To: Russell King - ARM Linux Cc: Baruch Siach, Antoine Tenart, davem, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, nadavh, stefanc, ymarkman, mw Hi, On Wed, Dec 12, 2018 at 10:30:33AM +0100, Antoine Tenart wrote: > On Tue, Dec 11, 2018 at 06:51:56PM +0000, Russell King - ARM Linux wrote: > > On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > > > That is, something like this, right? > > > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > index 125ea99418df..04cb0241ca2b 100644 > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > @@ -4404,13 +4404,18 @@ static void mvpp2_phylink_validate(struct net_device *dev, > > > switch (state->interface) { > > > case PHY_INTERFACE_MODE_10GKR: > > > case PHY_INTERFACE_MODE_XAUI: > > > + if (port->gop_id != 0) > > > + goto empty_set; > > > + /* Fall-through */ > > > case PHY_INTERFACE_MODE_NA: > > > - phylink_set(mask, 10000baseCR_Full); > > > - phylink_set(mask, 10000baseSR_Full); > > > - phylink_set(mask, 10000baseLR_Full); > > > - phylink_set(mask, 10000baseLRM_Full); > > > - phylink_set(mask, 10000baseER_Full); > > > - phylink_set(mask, 10000baseKR_Full); > > > + if (port->gop_id == 0) { > > > + phylink_set(mask, 10000baseCR_Full); > > > + phylink_set(mask, 10000baseSR_Full); > > > + phylink_set(mask, 10000baseLR_Full); > > > + phylink_set(mask, 10000baseLRM_Full); > > > + phylink_set(mask, 10000baseER_Full); > > > + phylink_set(mask, 10000baseKR_Full); > > > + } > > > /* Fall-through */ > > > case PHY_INTERFACE_MODE_RGMII: > > > case PHY_INTERFACE_MODE_RGMII_ID: > > > > > > > Yep, looks fine to me, thanks. > > This looks good, thanks! I'll send a v2. Well, I just got back to this, and looking at the beginning of the validate function invalid modes are already checked. So we do already have: case PHY_INTERFACE_MODE_10GKR: case PHY_INTERFACE_MODE_XAUI: if (port->gop_id != 0) goto empty_set; break; So it turns out the fix can be applied as-is. Thanks! Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-12 14:14 ` Antoine Tenart @ 2018-12-12 14:36 ` Baruch Siach 0 siblings, 0 replies; 10+ messages in thread From: Baruch Siach @ 2018-12-12 14:36 UTC (permalink / raw) To: Antoine Tenart Cc: Russell King - ARM Linux, davem, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, nadavh, stefanc, ymarkman, mw Hi Antoine, On Wed, Dec 12, 2018 at 03:14:51PM +0100, Antoine Tenart wrote: > On Wed, Dec 12, 2018 at 10:30:33AM +0100, Antoine Tenart wrote: > > On Tue, Dec 11, 2018 at 06:51:56PM +0000, Russell King - ARM Linux wrote: > > > On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > > > > That is, something like this, right? > > > > > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > > index 125ea99418df..04cb0241ca2b 100644 > > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > > @@ -4404,13 +4404,18 @@ static void mvpp2_phylink_validate(struct net_device *dev, > > > > switch (state->interface) { > > > > case PHY_INTERFACE_MODE_10GKR: > > > > case PHY_INTERFACE_MODE_XAUI: > > > > + if (port->gop_id != 0) > > > > + goto empty_set; > > > > + /* Fall-through */ > > > > case PHY_INTERFACE_MODE_NA: > > > > - phylink_set(mask, 10000baseCR_Full); > > > > - phylink_set(mask, 10000baseSR_Full); > > > > - phylink_set(mask, 10000baseLR_Full); > > > > - phylink_set(mask, 10000baseLRM_Full); > > > > - phylink_set(mask, 10000baseER_Full); > > > > - phylink_set(mask, 10000baseKR_Full); > > > > + if (port->gop_id == 0) { > > > > + phylink_set(mask, 10000baseCR_Full); > > > > + phylink_set(mask, 10000baseSR_Full); > > > > + phylink_set(mask, 10000baseLR_Full); > > > > + phylink_set(mask, 10000baseLRM_Full); > > > > + phylink_set(mask, 10000baseER_Full); > > > > + phylink_set(mask, 10000baseKR_Full); > > > > + } > > > > /* Fall-through */ > > > > case PHY_INTERFACE_MODE_RGMII: > > > > case PHY_INTERFACE_MODE_RGMII_ID: > > > > > > > > > > Yep, looks fine to me, thanks. > > > > This looks good, thanks! I'll send a v2. > > Well, I just got back to this, and looking at the beginning of the > validate function invalid modes are already checked. So we do already > have: > > case PHY_INTERFACE_MODE_10GKR: > case PHY_INTERFACE_MODE_XAUI: > if (port->gop_id != 0) > goto empty_set; > break; > > So it turns out the fix can be applied as-is. Right. I should have known that. Thanks for the fix. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-11 16:36 ` Russell King - ARM Linux 2018-12-11 17:53 ` Baruch Siach @ 2018-12-11 21:11 ` Stefan Chulski 2018-12-12 9:32 ` Antoine Tenart 1 sibling, 1 reply; 10+ messages in thread From: Stefan Chulski @ 2018-12-11 21:11 UTC (permalink / raw) To: Russell King - ARM Linux, Antoine Tenart Cc: davem, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, Nadav Haklai, Yan Markman, mw, Baruch Siach > -----Original Message----- > From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> > On Behalf Of Russell King - ARM Linux > Sent: Tuesday, December 11, 2018 6:37 PM > To: Antoine Tenart <antoine.tenart@bootlin.com> > Cc: davem@davemloft.net; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; thomas.petazzoni@bootlin.com; > maxime.chevallier@bootlin.com; gregory.clement@bootlin.com; > miquel.raynal@bootlin.com; Nadav Haklai <nadavh@marvell.com>; Stefan > Chulski <stefanc@marvell.com>; Yan Markman <ymarkman@marvell.com>; > mw@semihalf.com; Baruch Siach <baruch@tkos.co.il> > Subject: Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all > ports > > On Tue, Dec 11, 2018 at 05:32:28PM +0100, Antoine Tenart wrote: > > The mvpp2_phylink_validate() function sets all modes that are > > supported by a given PPv2 port. A recent change made all ports to > > advertise they support 10G modes in certain cases. This is not true, > > as only the port #0 can do so. This patch fixes it. > > > > Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules") > > Cc: Baruch Siach <baruch@tkos.co.il> > > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> > > --- > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > index 125ea99418df..88aa488054a8 100644 > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > @@ -4405,12 +4405,14 @@ static void mvpp2_phylink_validate(struct > net_device *dev, > > case PHY_INTERFACE_MODE_10GKR: > > case PHY_INTERFACE_MODE_XAUI: > > Are these modes supported on anything except port 0? If not, you should be > rejecting these, rather than just treating them as RGMII. In CP115(which has PPv2) PHY_INTERFACE_MODE_10GKR supported on ports 0 and 1 PHY_INTERFACE_MODE_XAUI/PHY_INTERFACE_MODE_RXAUI supported only on port 0. Best Regards. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-11 21:11 ` Stefan Chulski @ 2018-12-12 9:32 ` Antoine Tenart 0 siblings, 0 replies; 10+ messages in thread From: Antoine Tenart @ 2018-12-12 9:32 UTC (permalink / raw) To: Stefan Chulski Cc: Russell King - ARM Linux, Antoine Tenart, davem, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, Nadav Haklai, Yan Markman, mw, Baruch Siach Hi Stefan, On Tue, Dec 11, 2018 at 09:11:31PM +0000, Stefan Chulski wrote: > > > > > Are these modes supported on anything except port 0? If not, you should be > > rejecting these, rather than just treating them as RGMII. > > In CP115(which has PPv2) PHY_INTERFACE_MODE_10GKR supported on ports 0 and 1 > PHY_INTERFACE_MODE_XAUI/PHY_INTERFACE_MODE_RXAUI supported only on port 0. That's right. But I think we need to first fix this, and then when adding support for the cp115 we'll rework this. We will need a way to differentiate the CP110 PPv2 from the CP115 PPv2. Thanks! Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports 2018-12-11 16:32 [PATCH net] net: mvpp2: 10G modes aren't supported on all ports Antoine Tenart 2018-12-11 16:36 ` Russell King - ARM Linux @ 2018-12-18 22:49 ` David Miller 1 sibling, 0 replies; 10+ messages in thread From: David Miller @ 2018-12-18 22:49 UTC (permalink / raw) To: antoine.tenart Cc: linux, netdev, linux-kernel, thomas.petazzoni, maxime.chevallier, gregory.clement, miquel.raynal, nadavh, stefanc, ymarkman, mw, baruch From: Antoine Tenart <antoine.tenart@bootlin.com> Date: Tue, 11 Dec 2018 17:32:28 +0100 > The mvpp2_phylink_validate() function sets all modes that are > supported by a given PPv2 port. A recent change made all ports to > advertise they support 10G modes in certain cases. This is not true, > as only the port #0 can do so. This patch fixes it. > > Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules") > Cc: Baruch Siach <baruch@tkos.co.il> > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> Applied, thank you. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-12-18 22:49 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-12-11 16:32 [PATCH net] net: mvpp2: 10G modes aren't supported on all ports Antoine Tenart 2018-12-11 16:36 ` Russell King - ARM Linux 2018-12-11 17:53 ` Baruch Siach 2018-12-11 18:51 ` Russell King - ARM Linux 2018-12-12 9:30 ` Antoine Tenart 2018-12-12 14:14 ` Antoine Tenart 2018-12-12 14:36 ` Baruch Siach 2018-12-11 21:11 ` Stefan Chulski 2018-12-12 9:32 ` Antoine Tenart 2018-12-18 22:49 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).