From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe LEROY <christophe.leroy@c-s.fr>,
Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kgdb-bugreport@lists.sourceforge.net, stable@vger.kernel.org,
me@tobin.cc
Subject: Re: [PATCH] kdb: use correct pointer when 'btc' calls 'btt'
Date: Thu, 27 Sep 2018 21:09:28 +1000 [thread overview]
Message-ID: <877ej7urh3.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <760ed3ff-43d9-75e5-b36c-aaa7871ffe50@c-s.fr>
Christophe LEROY <christophe.leroy@c-s.fr> writes:
> Le 26/09/2018 à 13:11, Daniel Thompson a écrit :
>> On 16/09/2018 20:06, Daniel Thompson wrote:
>>> On Fri, Sep 14, 2018 at 12:35:44PM +0000, Christophe Leroy wrote:
>>>> On a powerpc 8xx, 'btc' fails as follows:
>>>> Entering kdb (current=0x(ptrval), pid 282) due to Keyboard Entry
...
>>>>
>>>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>>> Cc: <stable@vger.kernel.org> # 4.15+
>>>
>>> Would a Fixes: be better here?
>>> Fixes: ad67b74d2469d9b82 ("printk: hash addresses printed with %p")
>>
>> Christophe, When you add the Fixes: could you also add my
>>
>> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Ok, thanks for the review, but do I have to do anything really ?
>
> The Fixes: and now your Reviewed-by: appear automatically in patchwork
> (https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=65715),
> so I believe they'll be automatically included when Jason or someone
> else takes the patch, no ?
patchwork won't add the Fixes tag from the reply, it needs to be in the
original mail.
See:
https://github.com/getpatchwork/patchwork/issues/151
cheers
next prev parent reply other threads:[~2018-09-27 11:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 12:35 [PATCH] kdb: use correct pointer when 'btc' calls 'btt' Christophe Leroy
2018-09-16 19:06 ` Daniel Thompson
2018-09-16 22:18 ` Tobin C. Harding
2018-09-26 11:11 ` Daniel Thompson
2018-09-26 11:19 ` Christophe LEROY
2018-09-27 11:09 ` Michael Ellerman [this message]
2018-09-27 11:30 ` Christophe LEROY
2018-09-28 12:57 ` Michael Ellerman
2018-10-01 19:52 ` Jason Wessel
2018-11-10 21:42 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ej7urh3.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@c-s.fr \
--cc=daniel.thompson@linaro.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=me@tobin.cc \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).