From: NeilBrown <neilb@suse.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Ming Lei <tom.leiming@gmail.com>,
linux-kernel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
Javier Gonzalez <jg@lightnvm.io>
Subject: Re: [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.
Date: Thu, 11 May 2017 10:58:11 +1000 [thread overview]
Message-ID: <877f1omcpo.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <149369628671.5146.4865312503373040039.stgit@noble>
[-- Attachment #1: Type: text/plain, Size: 3986 bytes --]
On Tue, May 02 2017, NeilBrown wrote:
> This is a revision of my series of patches working
> towards removing the bioset work queues.
Hi Jens,
could I get some feed-back about your thoughts on this series?
Will you apply it? When? Do I need to resend anything?
Would you like a git-pull request? If so, what should I base it on?
There is a minor conflict with drivers/block/zram/zram_drv.c
as it dropped the call to blk_queue_split() recently, but otherwise it
still applies.
Thanks,
NeilBrown
>
> This set is based on Linus' tree as for today (2nd May) plus
> the for-linus branch from Shaohua's md/raid tree.
>
> This series adds a fix for the new lightnvm/pblk-read code
> and discards bioset_create_nobvec() in favor of a flag arg to
> bioset_create(). There are also minor fixes and a little
> code clean-up.
>
> I hope to eventually get rid of the new BIOSET_NEED_RESCUER flag,
> but that needs work ing dm and probably bcache first.
>
> Thanks,
> NeilBrown
>
>
> ---
>
> NeilBrown (13):
> blk: remove bio_set arg from blk_queue_split()
> blk: replace bioset_create_nobvec() with a flags arg to bioset_create()
> blk: make the bioset rescue_workqueue optional.
> blk: use non-rescuing bioset for q->bio_split.
> block: Improvements to bounce-buffer handling
> rbd: use bio_clone_fast() instead of bio_clone()
> drbd: use bio_clone_fast() instead of bio_clone()
> pktcdvd: use bio_clone_fast() instead of bio_clone()
> lightnvm/pblk-read: use bio_clone_fast()
> xen-blkfront: remove bio splitting.
> bcache: use kmalloc to allocate bio in bch_data_verify()
> block: remove bio_clone() and all references.
> block: don't check for BIO_MAX_PAGES in blk_bio_segment_split()
>
>
> Documentation/block/biodoc.txt | 2 -
> block/bio.c | 72 ++++++++++++++++-------------------
> block/blk-core.c | 4 +-
> block/blk-merge.c | 31 ++-------------
> block/blk-mq.c | 2 -
> block/bounce.c | 32 +++++++++++++---
> drivers/block/drbd/drbd_int.h | 3 +
> drivers/block/drbd/drbd_main.c | 11 +++++
> drivers/block/drbd/drbd_req.c | 2 -
> drivers/block/drbd/drbd_req.h | 2 -
> drivers/block/pktcdvd.c | 14 +++++--
> drivers/block/ps3vram.c | 2 -
> drivers/block/rbd.c | 16 +++++++-
> drivers/block/rsxx/dev.c | 2 -
> drivers/block/umem.c | 2 -
> drivers/block/xen-blkfront.c | 54 +-------------------------
> drivers/block/zram/zram_drv.c | 2 -
> drivers/lightnvm/pblk-init.c | 16 ++++++--
> drivers/lightnvm/pblk-read.c | 2 -
> drivers/lightnvm/pblk.h | 1
> drivers/lightnvm/rrpc.c | 2 -
> drivers/md/bcache/debug.c | 2 -
> drivers/md/bcache/super.c | 6 ++-
> drivers/md/dm-crypt.c | 2 -
> drivers/md/dm-io.c | 2 -
> drivers/md/dm.c | 5 +-
> drivers/md/md.c | 6 +--
> drivers/md/raid1.c | 2 -
> drivers/md/raid10.c | 2 -
> drivers/md/raid5-cache.c | 2 -
> drivers/md/raid5-ppl.c | 2 -
> drivers/md/raid5.c | 2 -
> drivers/s390/block/dcssblk.c | 2 -
> drivers/s390/block/xpram.c | 2 -
> drivers/target/target_core_iblock.c | 2 -
> fs/block_dev.c | 2 -
> fs/btrfs/extent_io.c | 3 +
> fs/xfs/xfs_super.c | 3 +
> include/linux/bio.h | 12 ++----
> include/linux/blkdev.h | 3 -
> 40 files changed, 162 insertions(+), 174 deletions(-)
>
> --
> Signature
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-05-11 0:58 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 3:42 [PATCH 00/13] block: assorted cleanup for bio splitting and cloning NeilBrown
2017-05-02 3:42 ` [PATCH 03/13] blk: make the bioset rescue_workqueue optional NeilBrown
2017-05-02 8:14 ` Christoph Hellwig
2017-05-02 11:00 ` Ming Lei
2017-05-02 22:10 ` NeilBrown
2017-05-02 22:34 ` [PATCH 03/13 V2] " NeilBrown
2017-05-03 3:24 ` Ming Lei
2017-05-02 3:42 ` [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() NeilBrown
2017-05-02 8:06 ` Christoph Hellwig
2017-05-02 21:47 ` NeilBrown
2017-05-02 9:40 ` Ming Lei
2017-05-02 3:42 ` [PATCH 01/13] blk: remove bio_set arg from blk_queue_split() NeilBrown
2017-05-02 10:44 ` javigon
2017-05-02 3:42 ` [PATCH 05/13] block: Improvements to bounce-buffer handling NeilBrown
2017-05-02 8:13 ` Christoph Hellwig
2017-05-02 11:56 ` Ming Lei
2017-05-02 3:42 ` [PATCH 04/13] blk: use non-rescuing bioset for q->bio_split NeilBrown
2017-05-02 11:54 ` Ming Lei
2017-05-02 23:21 ` [PATCH 04/13 V2] " NeilBrown
2017-05-02 3:42 ` [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast() NeilBrown
2017-05-02 8:15 ` Christoph Hellwig
2017-05-02 11:22 ` Javier González
2017-05-02 21:51 ` NeilBrown
2017-05-03 6:42 ` Javier González
2017-05-02 3:42 ` [PATCH 10/13] xen-blkfront: remove bio splitting NeilBrown
2017-05-02 8:15 ` Christoph Hellwig
2017-05-02 3:42 ` [PATCH 07/13] drbd: use bio_clone_fast() instead of bio_clone() NeilBrown
2017-05-02 23:20 ` [PATCH 07/13 V2] " NeilBrown
2017-05-02 3:42 ` [PATCH 06/13] rbd: " NeilBrown
2017-05-02 3:42 ` [PATCH 08/13] pktcdvd: " NeilBrown
2017-05-02 3:42 ` [PATCH 13/13] block: don't check for BIO_MAX_PAGES in blk_bio_segment_split() NeilBrown
2017-05-02 8:15 ` Christoph Hellwig
2017-05-02 10:22 ` Ming Lei
2017-05-02 22:54 ` NeilBrown
2017-05-02 23:50 ` Ming Lei
2017-05-02 3:42 ` [PATCH 11/13] bcache: use kmalloc to allocate bio in bch_data_verify() NeilBrown
2017-05-02 3:42 ` [PATCH 12/13] block: remove bio_clone() and all references NeilBrown
2017-05-11 0:58 ` NeilBrown [this message]
2017-06-16 5:54 ` [PATCH 00/13] block: assorted cleanup for bio splitting and cloning NeilBrown
2017-06-16 6:42 ` Christoph Hellwig
2017-06-16 7:30 ` NeilBrown
2017-06-16 7:34 ` Christoph Hellwig
2017-06-16 20:45 ` Jens Axboe
2017-06-18 4:40 ` NeilBrown
2017-06-18 4:40 ` NeilBrown
2017-06-18 4:38 NeilBrown
2017-06-18 18:41 ` Jens Axboe
2017-06-18 21:36 ` NeilBrown
2017-11-20 16:43 ` Mike Snitzer
2017-11-21 0:34 ` [dm-devel] " NeilBrown
2017-11-21 1:35 ` Mike Snitzer
2017-11-21 12:10 ` Mike Snitzer
2017-11-21 12:43 ` Mike Snitzer
2017-11-21 19:44 ` [dm-devel] " NeilBrown
2017-11-21 19:50 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f1omcpo.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=axboe@kernel.dk \
--cc=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).