Re: [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.

From: NeilBrown <neilb@suse.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Ming Lei <tom.leiming@gmail.com>,
	linux-kernel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
	Javier Gonzalez <jg@lightnvm.io>
Subject: Re: [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.
Date: Fri, 16 Jun 2017 15:54:30 +1000	[thread overview]
Message-ID: <87shj05vft.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <877f1omcpo.fsf@notabene.neil.brown.name>

[-- Attachment #1: Type: text/plain, Size: 4396 bytes --]

On Thu, May 11 2017, NeilBrown wrote:

> On Tue, May 02 2017, NeilBrown wrote:
>
>> This is a revision of my series of patches working
>> towards removing the bioset work queues.
>
> Hi Jens,
>  could I get some feed-back about your thoughts on this series?
>  Will you apply it?  When?  Do I need to resend anything?
>  Would you like a git-pull request?  If so, what should I base it on?
>  There is a minor conflict with drivers/block/zram/zram_drv.c
>  as it dropped the call to blk_queue_split() recently, but otherwise it
>  still applies.

Hi Jens,
 I didn't hear back ... have you had a chance to look?
 In case it helps, you can pull the full set, based on a recent Linus tree,
 from
     git://neil.brown.name/linux bioset

 or I can resend the patches if you like.

Thanks,
NeilBrown

>
> Thanks,
> NeilBrown
>
>
>>
>> This set is based on Linus' tree as for today (2nd May) plus
>> the for-linus branch from Shaohua's md/raid tree.
>>
>> This series adds a fix for the new lightnvm/pblk-read code
>> and discards bioset_create_nobvec() in favor of a flag arg to
>> bioset_create().  There are also minor fixes and a little
>> code clean-up.
>>
>> I hope to eventually get rid of the new BIOSET_NEED_RESCUER flag,
>> but that needs work ing dm and probably bcache first.
>>
>> Thanks,
>> NeilBrown
>>
>>
>> ---
>>
>> NeilBrown (13):
>>       blk: remove bio_set arg from blk_queue_split()
>>       blk: replace bioset_create_nobvec() with a flags arg to bioset_create()
>>       blk: make the bioset rescue_workqueue optional.
>>       blk: use non-rescuing bioset for q->bio_split.
>>       block: Improvements to bounce-buffer handling
>>       rbd: use bio_clone_fast() instead of bio_clone()
>>       drbd: use bio_clone_fast() instead of bio_clone()
>>       pktcdvd: use bio_clone_fast() instead of bio_clone()
>>       lightnvm/pblk-read: use bio_clone_fast()
>>       xen-blkfront: remove bio splitting.
>>       bcache: use kmalloc to allocate bio in bch_data_verify()
>>       block: remove bio_clone() and all references.
>>       block: don't check for BIO_MAX_PAGES in blk_bio_segment_split()
>>
>>
>>  Documentation/block/biodoc.txt      |    2 -
>>  block/bio.c                         |   72 ++++++++++++++++-------------------
>>  block/blk-core.c                    |    4 +-
>>  block/blk-merge.c                   |   31 ++-------------
>>  block/blk-mq.c                      |    2 -
>>  block/bounce.c                      |   32 +++++++++++++---
>>  drivers/block/drbd/drbd_int.h       |    3 +
>>  drivers/block/drbd/drbd_main.c      |   11 +++++
>>  drivers/block/drbd/drbd_req.c       |    2 -
>>  drivers/block/drbd/drbd_req.h       |    2 -
>>  drivers/block/pktcdvd.c             |   14 +++++--
>>  drivers/block/ps3vram.c             |    2 -
>>  drivers/block/rbd.c                 |   16 +++++++-
>>  drivers/block/rsxx/dev.c            |    2 -
>>  drivers/block/umem.c                |    2 -
>>  drivers/block/xen-blkfront.c        |   54 +-------------------------
>>  drivers/block/zram/zram_drv.c       |    2 -
>>  drivers/lightnvm/pblk-init.c        |   16 ++++++--
>>  drivers/lightnvm/pblk-read.c        |    2 -
>>  drivers/lightnvm/pblk.h             |    1 
>>  drivers/lightnvm/rrpc.c             |    2 -
>>  drivers/md/bcache/debug.c           |    2 -
>>  drivers/md/bcache/super.c           |    6 ++-
>>  drivers/md/dm-crypt.c               |    2 -
>>  drivers/md/dm-io.c                  |    2 -
>>  drivers/md/dm.c                     |    5 +-
>>  drivers/md/md.c                     |    6 +--
>>  drivers/md/raid1.c                  |    2 -
>>  drivers/md/raid10.c                 |    2 -
>>  drivers/md/raid5-cache.c            |    2 -
>>  drivers/md/raid5-ppl.c              |    2 -
>>  drivers/md/raid5.c                  |    2 -
>>  drivers/s390/block/dcssblk.c        |    2 -
>>  drivers/s390/block/xpram.c          |    2 -
>>  drivers/target/target_core_iblock.c |    2 -
>>  fs/block_dev.c                      |    2 -
>>  fs/btrfs/extent_io.c                |    3 +
>>  fs/xfs/xfs_super.c                  |    3 +
>>  include/linux/bio.h                 |   12 ++----
>>  include/linux/blkdev.h              |    3 -
>>  40 files changed, 162 insertions(+), 174 deletions(-)
>>
>> --
>> Signature

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]