From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Kevin Hilman <khilman@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
Sekhar Nori <nsekhar@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue
Date: Tue, 2 Aug 2016 01:13:40 +0000 [thread overview]
Message-ID: <877fc0hte3.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20160801233610.10479-1-khilman@baylibre.com>
Hi Kevin
Thank you for your patch
> An ASoC driver using simple-card, when built as a module gets the
> following error at module load time:
>
> [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0)
> [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0)
>
> fix this by including simple-card-utils.o symbols in the module build
> its symols are resolved correctly.
>
> Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp,
> with all of ASoC built as modules.
>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
Hmm... strange...
simple-card-utils will be used not only simple-card in the future,
thus it should be build separately.
And, snd_soc_of_parse_daifmt() and snd_soc_of_parse_card_name() are
already exported on soc-core.c ?
I tried it as module, but no error for me
...
CHK kernel/config_data.h
LD sound/soc/generic/built-in.o
CC [M] sound/soc/generic/simple-card-utils.o
CC [M] sound/soc/generic/simple-card.o
LD [M] sound/soc/generic/snd-soc-simple-card.o
LD sound/soc/built-in.o
LD sound/built-in.o
...
MODPOST 7 modules
Kernel: arch/arm/boot/Image is ready
Kernel: arch/arm/boot/Image is ready
CC sound/soc/generic/simple-card-utils.mod.o
CC sound/soc/generic/snd-soc-simple-card.mod.o
GZIP arch/arm/boot/compressed/piggy_data
LD [M] sound/soc/generic/simple-card-utils.ko
LD [M] sound/soc/generic/snd-soc-simple-card.ko
AS arch/arm/boot/compressed/piggy.o
LD arch/arm/boot/compressed/vmlinux
OBJCOPY arch/arm/boot/zImage
Kernel: arch/arm/boot/zImage is ready
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2016-08-02 1:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 23:36 [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Kevin Hilman
2016-08-02 1:13 ` Kuninori Morimoto [this message]
2016-08-02 2:40 ` Kevin Hilman
2016-08-02 3:22 ` [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Kuninori Morimoto
2016-08-02 18:11 ` Mark Brown
2016-08-02 18:50 ` Kevin Hilman
2016-08-02 19:41 ` Mark Brown
2016-08-08 14:18 ` [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Sekhar Nori
2016-08-09 0:26 ` Kuninori Morimoto
2016-08-09 6:49 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fc0hte3.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).