From: Kevin Hilman <khilman@baylibre.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Sekhar Nori <nsekhar@ti.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue
Date: Mon, 1 Aug 2016 16:36:08 -0700 [thread overview]
Message-ID: <20160801233610.10479-1-khilman@baylibre.com> (raw)
An ASoC driver using simple-card, when built as a module gets the
following error at module load time:
[ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0)
[ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0)
fix this by including simple-card-utils.o symbols in the module build
its symols are resolved correctly.
Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp,
with all of ASoC built as modules.
Cc: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
sound/soc/generic/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/generic/Makefile b/sound/soc/generic/Makefile
index 45602ca8536e..ff0c55eee4f7 100644
--- a/sound/soc/generic/Makefile
+++ b/sound/soc/generic/Makefile
@@ -2,4 +2,8 @@ obj-$(CONFIG_SND_SIMPLE_CARD_UTILS) := simple-card-utils.o
snd-soc-simple-card-objs := simple-card.o
+ifneq ($(CONFIG_SND_SIMPLE_CARD_UTILS),)
+snd-soc-simple-card-objs += simple-card-utils.o
+endif
+
obj-$(CONFIG_SND_SIMPLE_CARD) += snd-soc-simple-card.o
--
2.9.0
next reply other threads:[~2016-08-01 23:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 23:36 Kevin Hilman [this message]
2016-08-02 1:13 ` [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Kuninori Morimoto
2016-08-02 2:40 ` Kevin Hilman
2016-08-02 3:22 ` [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Kuninori Morimoto
2016-08-02 18:11 ` Mark Brown
2016-08-02 18:50 ` Kevin Hilman
2016-08-02 19:41 ` Mark Brown
2016-08-08 14:18 ` [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Sekhar Nori
2016-08-09 0:26 ` Kuninori Morimoto
2016-08-09 6:49 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801233610.10479-1-khilman@baylibre.com \
--to=khilman@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).