* [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement
@ 2019-08-10 4:59 Gustavo A. R. Silva
2019-08-10 6:53 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-10 4:59 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker
Cc: linux-sh, linux-kernel, Gustavo A. R. Silva, Guenter Roeck
Add missing break statement in order to prevent the code from
erroneously falling through to case SH_BREAKPOINT_WRITE.
Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.
arch/sh/kernel/hw_breakpoint.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
index 3bd010b4c55f..f10d64311127 100644
--- a/arch/sh/kernel/hw_breakpoint.c
+++ b/arch/sh/kernel/hw_breakpoint.c
@@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
switch (sh_type) {
case SH_BREAKPOINT_READ:
*gen_type = HW_BREAKPOINT_R;
+ break;
case SH_BREAKPOINT_WRITE:
*gen_type = HW_BREAKPOINT_W;
break;
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement
2019-08-10 4:59 [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement Gustavo A. R. Silva
@ 2019-08-10 6:53 ` Geert Uytterhoeven
2019-08-10 12:53 ` Guenter Roeck
2019-08-13 8:50 ` Yoshinori Sato
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-08-10 6:53 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Yoshinori Sato, Rich Felker, Linux-sh list,
Linux Kernel Mailing List, Guenter Roeck
On Sat, Aug 10, 2019 at 6:59 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement
2019-08-10 4:59 [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement Gustavo A. R. Silva
2019-08-10 6:53 ` Geert Uytterhoeven
@ 2019-08-10 12:53 ` Guenter Roeck
2019-08-13 8:50 ` Yoshinori Sato
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2019-08-10 12:53 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Yoshinori Sato, Rich Felker, linux-sh, linux-kernel
On Fri, Aug 09, 2019 at 11:59:44PM -0500, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.
>
> arch/sh/kernel/hw_breakpoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
> index 3bd010b4c55f..f10d64311127 100644
> --- a/arch/sh/kernel/hw_breakpoint.c
> +++ b/arch/sh/kernel/hw_breakpoint.c
> @@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
> switch (sh_type) {
> case SH_BREAKPOINT_READ:
> *gen_type = HW_BREAKPOINT_R;
> + break;
> case SH_BREAKPOINT_WRITE:
> *gen_type = HW_BREAKPOINT_W;
> break;
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement
2019-08-10 4:59 [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement Gustavo A. R. Silva
2019-08-10 6:53 ` Geert Uytterhoeven
2019-08-10 12:53 ` Guenter Roeck
@ 2019-08-13 8:50 ` Yoshinori Sato
2 siblings, 0 replies; 4+ messages in thread
From: Yoshinori Sato @ 2019-08-13 8:50 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Rich Felker, linux-sh, linux-kernel, Guenter Roeck
On Sat, 10 Aug 2019 13:59:44 +0900,
Gustavo A. R. Silva wrote:
>
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>
> If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.
>
> arch/sh/kernel/hw_breakpoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
> index 3bd010b4c55f..f10d64311127 100644
> --- a/arch/sh/kernel/hw_breakpoint.c
> +++ b/arch/sh/kernel/hw_breakpoint.c
> @@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
> switch (sh_type) {
> case SH_BREAKPOINT_READ:
> *gen_type = HW_BREAKPOINT_R;
> + break;
> case SH_BREAKPOINT_WRITE:
> *gen_type = HW_BREAKPOINT_W;
> break;
> --
> 2.22.0
>
Applied sh-next.
Thanks.
--
Yosinori Sato
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-13 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-10 4:59 [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement Gustavo A. R. Silva
2019-08-10 6:53 ` Geert Uytterhoeven
2019-08-10 12:53 ` Guenter Roeck
2019-08-13 8:50 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).