From: email@example.com (Eric W. Biederman) To: Andy Lutomirski <firstname.lastname@example.org> Cc: Al Viro <email@example.com>, Linus Torvalds <firstname.lastname@example.org>, Jann Horn <email@example.com>, Linux API <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com>, linux-fsdevel <firstname.lastname@example.org>, David Drysdale <email@example.com> Subject: Re: new ...at() flag: AT_NO_JUMPS Date: Fri, 05 May 2017 15:04:33 -0500 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CALCETrVQ2fwDZOsGSoLyRb6Qjp4nszfDjOPSYi0kzqt23Aw1NA@mail.gmail.com> (Andy Lutomirski's message of "Thu, 4 May 2017 21:44:04 -0700") Andy Lutomirski <email@example.com> writes: > On Thu, May 4, 2017 at 9:39 PM, Al Viro <firstname.lastname@example.org> wrote: >> On Thu, May 04, 2017 at 08:46:49PM -0700, Linus Torvalds wrote: >>> On Thu, May 4, 2017 at 7:47 PM, Jann Horn <email@example.com> wrote: >>> > >>> > Thread 1 starts an AT_BENEATH path walk using an O_PATH fd >>> > pointing to /srv/www/example.org/foo; the path given to the syscall is >>> > "bar/../../../../etc/passwd". The path walk enters the "bar" directory. >>> > Thread 2 moves /srv/www/example.org/foo/bar to >>> > /srv/www/example.org/bar. >>> > Thread 1 processes the rest of the path ("../../../../etc/passwd"), never >>> > hitting /srv/www/example.org/foo in the process. >>> > >>> > I'm not really familiar with the VFS internals, but from a coarse look >>> > at the patch, it seems like it wouldn't block this? >>> >>> I think you're right. >>> >>> I guess it would be safe for the RCU case due to the sequence number >>> check, but not the non-RCU case. >> >> Yes and no... FWIW, to exclude that it would suffice to have >> mount --rbind /src/www/example.org/foo /srv/www/example.org/foo done first. >> Then this kind of race will end up with -ENOENT due to path_connected() >> logics in follow_dotdot_rcu()/follow_dotdot(). I'm not sure about the >> intended applications, though - is that thing supposed to be used along with >> some horror like seccomp, or...? > > How hard would it be for the kernel to prevent this on its own? > Asking users to do the mount --rbind seems like it's asking for users > to forget to do it. The logic of path_connected checks every time you follow .. if the parent directory you find is below your starting directory. Mostly path_connected is optimized by noticing non-bind mounts and doing nothing. In this case we would need the is_subdir check every time we follow .. So it might just be cheaper not to follow .. Which leads to something else we need to be careful with. Suppose for whatever insane reason . is on a directory that has another directory mounted on top. Then following "some_dir/.." would result in a different directory than we were on. Eric
next prev parent reply other threads:[~2017-05-05 20:11 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-29 22:04 Al Viro 2017-04-29 23:17 ` Andy Lutomirski 2017-04-29 23:25 ` Al Viro 2017-04-30 1:13 ` Andy Lutomirski 2017-04-30 4:38 ` Matthew Wilcox 2017-04-30 16:10 ` Al Viro 2017-05-01 4:52 ` Andy Lutomirski 2017-05-01 5:15 ` Al Viro 2017-05-01 17:36 ` Jann Horn 2017-05-01 19:37 ` Andy Lutomirski 2017-05-05 0:30 ` Al Viro 2017-05-05 0:44 ` Andy Lutomirski 2017-05-05 1:06 ` Al Viro 2017-05-05 1:27 ` Linus Torvalds 2017-05-05 3:00 ` Al Viro 2017-05-05 4:01 ` Linus Torvalds 2017-05-05 4:31 ` Andy Lutomirski 2017-05-05 2:47 ` Jann Horn 2017-05-05 3:46 ` Linus Torvalds 2017-05-05 4:39 ` Al Viro 2017-05-05 4:44 ` Andy Lutomirski 2017-05-05 20:04 ` Eric W. Biederman [this message] 2017-05-05 20:28 ` Eric W. Biederman 2017-05-08 19:34 ` Mickaël Salaün 2017-05-18 8:50 ` David Drysdale 2017-09-10 20:26 Jürg Billeter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: new ...at() flag: AT_NO_JUMPS' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).