From: Michael Ellerman <mpe@ellerman.id.au>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
KVM list <kvm@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mie@igel.co.jp
Subject: Re: [GIT PULL] virtio: last minute fixup
Date: Wed, 11 May 2022 23:40:59 +1000 [thread overview]
Message-ID: <87a6bo89w4.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20220511125140.ormw47yluv4btiey@meerkat.local>
Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:
...
>
> I think we should simply disambiguate the trailer added by tooling like b4.
> Instead of using Link:, it can go back to using Message-Id, which is already
> standard with git -- it's trivial for git.kernel.org to link them to
> lore.kernel.org.
But my mailer, editor and terminal don't know what to do with a Message-Id.
Whereas they can all open an https link.
Making people paste message ids into lore to see the original submission
is not a win. People make enough fun of us already for still using email
to submit patches, let's not make their job any easier :)
> Before:
>
> Signed-off-by: Main Tainer <main.tainer@linux.dev>
> Link: https://lore.kernel.org/r/CAHk-=wgAk3NEJ2PHtb0jXzCUOGytiHLq=rzjkFKfpiuH-SROgA@mail.gmail.com
>
> After:
>
> Signed-off-by: Main Tainer <main.tainer@linux.dev>
> Message-Id: <CAHk-=wgAk3NEJ2PHtb0jXzCUOGytiHLq=rzjkFKfpiuH-SROgA@mail.gmail.com>
>
> This would allow people to still use Link: for things like linking to actual
> ML discussions. I know this pollutes commits a bit, but I would argue that
> this is a worthwhile trade-off that allows us to improve our automation and
> better scale maintainers.
I went back through the history and I'm pretty sure that the original use
for "Link:" was to link to the original submission, done by tip-bot
starting back in 2011:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f994d99cf140dbb637e49882891c89b3fd84becd
Prior to that there were no "Link:" tags, only "BugLink:".
But if people want to reclaim "Link:" for generic links then fine, but
let's still use a https link, just give it a different name.
eg. "PatchLink:", or "Submitted:" etc.
cheers
next prev parent reply other threads:[~2022-05-11 13:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 12:23 [GIT PULL] virtio: last minute fixup Michael S. Tsirkin
2022-05-10 18:23 ` Linus Torvalds
2022-05-10 23:12 ` Nathan Chancellor
2022-05-10 23:50 ` Linus Torvalds
2022-05-11 7:13 ` Michael S. Tsirkin
2022-05-11 12:51 ` Konstantin Ryabitsev
2022-05-11 13:40 ` Michael Ellerman [this message]
2022-05-11 16:31 ` Konstantin Ryabitsev
2022-05-12 2:07 ` Theodore Ts'o
2022-05-11 17:35 ` Dave Taht
2022-05-11 6:22 ` Michael S. Tsirkin
2022-05-11 10:12 ` Michael Ellerman
2022-05-11 16:20 ` Linus Torvalds
2022-05-12 13:30 ` Michael Ellerman
2022-05-12 17:10 ` Linus Torvalds
2022-05-12 17:19 ` Linus Torvalds
2022-05-13 14:14 ` Eric W. Biederman
2022-05-13 17:00 ` Jakub Kicinski
2022-05-16 9:03 ` Michael S. Tsirkin
2022-05-11 12:24 ` Jörg Rödel
2022-05-13 12:16 ` Michael S. Tsirkin
2022-05-10 18:31 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6bo89w4.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=konstantin@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mie@igel.co.jp \
--cc=mst@redhat.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).