From: "Jörg Rödel" <joro@8bytes.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
KVM list <kvm@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mie@igel.co.jp
Subject: Re: [GIT PULL] virtio: last minute fixup
Date: Wed, 11 May 2022 14:24:23 +0200 [thread overview]
Message-ID: <Ynuq9wMtJKBe8WOk@8bytes.org> (raw)
In-Reply-To: <CAHk-=wjPR+bj7P1O=MAQWXp0Mx2hHuNQ1acn6gS+mRo_kbo5Lg@mail.gmail.com>
On Tue, May 10, 2022 at 11:23:11AM -0700, Linus Torvalds wrote:
> And - once again - I want to complain about the "Link:" in that commit.
I have to say that for me (probably for others as well) those Link tags
pointing to the patch submission have quite some value:
1) First of all it is an easy proof that the patch was actually
submitted somewhere for public review before it went into a
maintainers tree.
2) The patch submission is often the entry point to the
discussion which lead to this patch. From that email I can
see what was discussed and often there is even a link to
previous versions and the discussions that happened there. It
helps to better understand how a patch came to be the way it
is. I know this should ideally be part of the commit message,
but in reality this is what I also use the link tag for.
3) When backporting a patch to a downstream kernel it often
helps a lot to see the whole patch-set the change was
submitted in, especially when it comes to fixes. With the
Link: tag the whole submission thread is easy to find.
I can stop adding them to patches if you want, but as I said, I think
there is some value in them which make me want to keep them.
Regards,
Joerg
next prev parent reply other threads:[~2022-05-11 12:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 12:23 [GIT PULL] virtio: last minute fixup Michael S. Tsirkin
2022-05-10 18:23 ` Linus Torvalds
2022-05-10 23:12 ` Nathan Chancellor
2022-05-10 23:50 ` Linus Torvalds
2022-05-11 7:13 ` Michael S. Tsirkin
2022-05-11 12:51 ` Konstantin Ryabitsev
2022-05-11 13:40 ` Michael Ellerman
2022-05-11 16:31 ` Konstantin Ryabitsev
2022-05-12 2:07 ` Theodore Ts'o
2022-05-11 17:35 ` Dave Taht
2022-05-11 6:22 ` Michael S. Tsirkin
2022-05-11 10:12 ` Michael Ellerman
2022-05-11 16:20 ` Linus Torvalds
2022-05-12 13:30 ` Michael Ellerman
2022-05-12 17:10 ` Linus Torvalds
2022-05-12 17:19 ` Linus Torvalds
2022-05-13 14:14 ` Eric W. Biederman
2022-05-13 17:00 ` Jakub Kicinski
2022-05-16 9:03 ` Michael S. Tsirkin
2022-05-11 12:24 ` Jörg Rödel [this message]
2022-05-13 12:16 ` Michael S. Tsirkin
2022-05-10 18:31 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynuq9wMtJKBe8WOk@8bytes.org \
--to=joro@8bytes.org \
--cc=konstantin@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mie@igel.co.jp \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).