From: Florian Weimer <fweimer@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux API <linux-api@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
Laura Abbott <labbott@redhat.com>,
Paul Burton <pburton@wavecomp.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h
Date: Mon, 17 Jun 2019 20:19:48 +0200 [thread overview]
Message-ID: <87a7egdqgr.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAHk-=wgiZNERDN7p-bsCzzYGRjeqTQw7kJxJnXAHVjqqO8PGrg@mail.gmail.com> (Linus Torvalds's message of "Mon, 17 Jun 2019 11:13:20 -0700")
* Linus Torvalds:
> On Mon, Jun 17, 2019 at 11:03 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> There's also __kernel_fd_set in <linux/posix_types.h>. I may have
>> lumped this up with <asm/posix_types.h>, but it has the same problem.
>
> Hmm.
>
> That one we might be able to just fix by renaming "fds_bits" to "__fds_bits".
>
> Unlike the "val[]" thing, I don't think anybody is supposed to access
> those fields directly.
Well, glibc already calls it __val …
> I think fd_set and friends are now supposed to be in <sys/select.h>
> anyway, and the "it was in <sys/types.h>" is all legacy.
Do you suggest to create a <linux/select.h> header to mirror this?
Thanks,
Florian
next prev parent reply other threads:[~2019-06-17 18:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 16:51 [PATCH] uapi: avoid namespace conflict in linux/posix_types.h Arnd Bergmann
2019-03-19 21:46 ` David Miller
2019-03-19 21:55 ` Florian Weimer
2019-05-07 22:50 ` Joseph Myers
2019-06-07 4:28 ` Florian Weimer
2019-06-07 18:27 ` Linus Torvalds
2019-06-07 18:43 ` Florian Weimer
2019-06-07 18:56 ` Linus Torvalds
2019-06-17 11:45 ` Florian Weimer
2019-06-17 17:49 ` Linus Torvalds
2019-06-17 18:02 ` Florian Weimer
2019-06-17 18:13 ` Linus Torvalds
2019-06-17 18:16 ` Linus Torvalds
2019-06-17 18:19 ` Florian Weimer [this message]
2019-06-17 18:48 ` Linus Torvalds
2019-06-18 7:44 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7egdqgr.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=joseph@codesourcery.com \
--cc=labbott@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pburton@wavecomp.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).