From: Peter Korsgaard <peter@korsgaard.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND 2/2] arm64: dts: meson: add libretech aml-s805x-ac board
Date: Wed, 14 Nov 2018 15:37:25 +0100 [thread overview]
Message-ID: <87a7mbvi6y.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181114103855.14571-1-jbrunet@baylibre.com> (Jerome Brunet's message of "Wed, 14 Nov 2018 11:38:55 +0100")
>>>>> "Jerome" == Jerome Brunet <jbrunet@baylibre.com> writes:
> From: Neil Armstrong <narmstrong@baylibre.com>
> Add Libretech aml-s805x-ac board (aka 'La Frite') support
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
..
> +#include "meson-gxl-s905x.dtsi"
> +
> +/ {
> + compatible = "libretech,aml-s805x-ac", "amlogic,s805x",
> + "amlogic,meson-gxl";
> + model = "Libre Computer Board AML-S805X-AC";
No mention of 'La Frite'?
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x0 0x0 0x20000000>;
> + };
Maybe add a comment that there's 1GB variants as well?
> +
> + vcck: regulator-vcck {
> + compatible = "regulator-fixed";
> + regulator-name = "VCCK";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&dc_5v>;
> +
> + /*
> + * This is controlled by GPIOAO_9 we reserve this but
> + * claiming it as done bellow reset the board anyway
s/bellow/below/
> +&spifc {
> + status = "okay";
> + pinctrl-0 = <&nor_pins>;
> + pinctrl-names = "default";
> +
> + w25q32: spi-flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <3000000>;
Is this 3MHz a limitation of the flash, board layout or SPI controller?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-11-14 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 10:19 [PATCH 0/2] arm64: dts: meson: add Libretech aml-s805x-ac support Jerome Brunet
2018-11-14 10:19 ` [PATCH 1/2] dt-bindings: arm: amlogic: add libretech aml-s805x-ac bindings Jerome Brunet
2018-11-14 10:19 ` [PATCH 2/2] arm64: dts: meson: add libretech aml-s805x-ac board Jerome Brunet
2018-11-14 10:38 ` [PATCH RESEND " Jerome Brunet
2018-11-14 14:37 ` Peter Korsgaard [this message]
2018-11-15 9:13 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7mbvi6y.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--subject='Re: [PATCH RESEND 2/2] arm64: dts: meson: add libretech aml-s805x-ac board' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).