linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2] add kernel param to force disable module load
@ 2012-02-01  2:33 Dave Young
  2012-02-02 20:28 ` Rusty Russell
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Young @ 2012-02-01  2:33 UTC (permalink / raw)
  To: rusty, linux-kernel

Sometimes we need to test a kernel of same version with code or config
option changes.

We already have sysctl to disable module load, but add a kernel
parameter will be more convenient.

Since modules_disabled is int, so here use bint type in core_param.
TODO: make sysctl accept bool and change modules_disabled to bool

Signed-off-by: Dave Young <dyoung@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
---
 Documentation/kernel-parameters.txt |    2 ++
 kernel/module.c                     |    1 +
 2 files changed, 3 insertions(+)

--- linux-2.6.orig/Documentation/kernel-parameters.txt	2012-01-31 13:07:06.000000000 +0800
+++ linux-2.6/Documentation/kernel-parameters.txt	2012-01-31 13:07:09.393362159 +0800
@@ -1833,6 +1833,8 @@ bytes respectively. Such letter suffixes
 			shutdown the other cpus.  Instead use the REBOOT_VECTOR
 			irq.
 
+	nomodule	Disable module load
+
 	nopat		[X86] Disable PAT (page attribute table extension of
 			pagetables) support.
 
--- linux-2.6.orig/kernel/module.c	2012-01-31 13:07:06.000000000 +0800
+++ linux-2.6/kernel/module.c	2012-01-31 13:07:34.196695573 +0800
@@ -105,6 +105,7 @@ struct list_head *kdb_modules = &modules
 
 /* Block module loading/unloading? */
 int modules_disabled = 0;
+core_param(nomodule, modules_disabled, bint, 0);
 
 /* Waiting for a module to finish initializing? */
 static DECLARE_WAIT_QUEUE_HEAD(module_wq);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] add kernel param to force disable module load
  2012-02-01  2:33 [PATCH 2/2] add kernel param to force disable module load Dave Young
@ 2012-02-02 20:28 ` Rusty Russell
  0 siblings, 0 replies; 4+ messages in thread
From: Rusty Russell @ 2012-02-02 20:28 UTC (permalink / raw)
  To: Dave Young, linux-kernel

On Wed, 1 Feb 2012 10:33:14 +0800, Dave Young <dyoung@redhat.com> wrote:
> Sometimes we need to test a kernel of same version with code or config
> option changes.
> 
> We already have sysctl to disable module load, but add a kernel
> parameter will be more convenient.
> 
> Since modules_disabled is int, so here use bint type in core_param.
> TODO: make sysctl accept bool and change modules_disabled to bool

Both applied.

Thanks!
Rusty.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] add kernel param to force disable module load
  2012-02-01  2:32 Dave Young
@ 2012-02-01  2:35 ` Dave Young
  0 siblings, 0 replies; 4+ messages in thread
From: Dave Young @ 2012-02-01  2:35 UTC (permalink / raw)
  To: rusty, linux-kernel

please ignore this empty one, sorry for the noise

On 02/01/2012 10:32 AM, Dave Young wrote:

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks
Dave

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] add kernel param to force disable module load
@ 2012-02-01  2:32 Dave Young
  2012-02-01  2:35 ` Dave Young
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Young @ 2012-02-01  2:32 UTC (permalink / raw)
  To: rusty, linux-kernel



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-03  3:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-01  2:33 [PATCH 2/2] add kernel param to force disable module load Dave Young
2012-02-02 20:28 ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2012-02-01  2:32 Dave Young
2012-02-01  2:35 ` Dave Young

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).