* [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU
@ 2020-03-06 3:17 Randy Dunlap
2020-03-06 8:00 ` Geert Uytterhoeven
2020-03-06 14:28 ` Laurent Pinchart
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-03-06 3:17 UTC (permalink / raw)
To: dri-devel, LKML
Cc: Laurent Pinchart, Kieran Bingham, Linux-Renesas, Koji Matsuoka,
David Airlie
From: Randy Dunlap <rdunlap@infradead.org>
DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
symbols do not depend on DRM_RCAR_DU, the menu presentation is
broken for these and following non-R-Car Kconfig symbols.
Is it safe/appropriate to make all of these symbols depend on
DRM_RCAR_DU? It make the kconfig menu presentation much cleaner.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Cc: Dave Airlie <airlied@linux.ie>
---
drivers/gpu/drm/rcar-du/Kconfig | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig
+++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig
@@ -24,6 +24,7 @@ config DRM_RCAR_CMM
config DRM_RCAR_DW_HDMI
tristate "R-Car DU Gen3 HDMI Encoder Support"
depends on DRM && OF
+ depends on DRM_RCAR_DU
select DRM_DW_HDMI
help
Enable support for R-Car Gen3 internal HDMI encoder.
@@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI
config DRM_RCAR_LVDS
tristate "R-Car DU LVDS Encoder Support"
depends on DRM && DRM_BRIDGE && OF
+ depends on DRM_RCAR_DU
select DRM_PANEL
select OF_FLATTREE
select OF_OVERLAY
@@ -47,4 +49,5 @@ config DRM_RCAR_VSP
config DRM_RCAR_WRITEBACK
bool
+ depends on DRM_RCAR_DU
default y if ARM64
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU
2020-03-06 3:17 [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU Randy Dunlap
@ 2020-03-06 8:00 ` Geert Uytterhoeven
2020-03-06 14:28 ` Laurent Pinchart
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-03-06 8:00 UTC (permalink / raw)
To: Randy Dunlap
Cc: dri-devel, LKML, Laurent Pinchart, Kieran Bingham, Linux-Renesas,
Koji Matsuoka, David Airlie
Hi Randy,
Thanks for your patch!
On Fri, Mar 6, 2020 at 4:18 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
> symbols do not depend on DRM_RCAR_DU, the menu presentation is
> broken for these and following non-R-Car Kconfig symbols.
>
> Is it safe/appropriate to make all of these symbols depend on
> DRM_RCAR_DU? It make the kconfig menu presentation much cleaner.
I think it is.
But I'd use a big "#if DRM_RCAR_DU" block instead of individual dependencies.
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> --- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig
> +++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig
> @@ -24,6 +24,7 @@ config DRM_RCAR_CMM
> config DRM_RCAR_DW_HDMI
> tristate "R-Car DU Gen3 HDMI Encoder Support"
> depends on DRM && OF
> + depends on DRM_RCAR_DU
> select DRM_DW_HDMI
> help
> Enable support for R-Car Gen3 internal HDMI encoder.
> @@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI
> config DRM_RCAR_LVDS
> tristate "R-Car DU LVDS Encoder Support"
> depends on DRM && DRM_BRIDGE && OF
> + depends on DRM_RCAR_DU
> select DRM_PANEL
> select OF_FLATTREE
> select OF_OVERLAY
> @@ -47,4 +49,5 @@ config DRM_RCAR_VSP
>
> config DRM_RCAR_WRITEBACK
> bool
> + depends on DRM_RCAR_DU
> default y if ARM64
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU
2020-03-06 3:17 [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU Randy Dunlap
2020-03-06 8:00 ` Geert Uytterhoeven
@ 2020-03-06 14:28 ` Laurent Pinchart
2020-03-06 15:09 ` Randy Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2020-03-06 14:28 UTC (permalink / raw)
To: Randy Dunlap
Cc: dri-devel, LKML, Kieran Bingham, Linux-Renesas, Koji Matsuoka,
David Airlie
Hi Randy,
On Thu, Mar 05, 2020 at 07:17:49PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
> symbols do not depend on DRM_RCAR_DU, the menu presentation is
> broken for these and following non-R-Car Kconfig symbols.
>
> Is it safe/appropriate to make all of these symbols depend on
> DRM_RCAR_DU? It make the kconfig menu presentation much cleaner.
As those drivers are useless without DRM_RCAR_DU, I'm fine with this
change. It however prevents test-compiling those drivers when
DRM_RCAR_DU is disabled, but I see little reason to do so anyway, I
expect compile tests to aim for as large coverage as possible, and they
should thus enable DRM_RCAR_DU.
Would you like to submit a new version without this question, and
possibly addressing Geert's concern if you think it's appropriate, or
should I do so when applying ?
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Cc: Dave Airlie <airlied@linux.ie>
> ---
> drivers/gpu/drm/rcar-du/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig
> +++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig
> @@ -24,6 +24,7 @@ config DRM_RCAR_CMM
> config DRM_RCAR_DW_HDMI
> tristate "R-Car DU Gen3 HDMI Encoder Support"
> depends on DRM && OF
> + depends on DRM_RCAR_DU
> select DRM_DW_HDMI
> help
> Enable support for R-Car Gen3 internal HDMI encoder.
> @@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI
> config DRM_RCAR_LVDS
> tristate "R-Car DU LVDS Encoder Support"
> depends on DRM && DRM_BRIDGE && OF
> + depends on DRM_RCAR_DU
> select DRM_PANEL
> select OF_FLATTREE
> select OF_OVERLAY
> @@ -47,4 +49,5 @@ config DRM_RCAR_VSP
>
> config DRM_RCAR_WRITEBACK
> bool
> + depends on DRM_RCAR_DU
> default y if ARM64
Is this one needed ? The symbol should not be shown in the kconfig menu
as it has no text.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU
2020-03-06 14:28 ` Laurent Pinchart
@ 2020-03-06 15:09 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-03-06 15:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, LKML, Kieran Bingham, Linux-Renesas, Koji Matsuoka,
David Airlie
On 3/6/20 6:28 AM, Laurent Pinchart wrote:
> Hi Randy,
>
> On Thu, Mar 05, 2020 at 07:17:49PM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
>> symbols do not depend on DRM_RCAR_DU, the menu presentation is
>> broken for these and following non-R-Car Kconfig symbols.
>>
>> Is it safe/appropriate to make all of these symbols depend on
>> DRM_RCAR_DU? It make the kconfig menu presentation much cleaner.
>
> As those drivers are useless without DRM_RCAR_DU, I'm fine with this
> change. It however prevents test-compiling those drivers when
> DRM_RCAR_DU is disabled, but I see little reason to do so anyway, I
> expect compile tests to aim for as large coverage as possible, and they
> should thus enable DRM_RCAR_DU.
>
> Would you like to submit a new version without this question, and
> possibly addressing Geert's concern if you think it's appropriate, or
> should I do so when applying ?
>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>> Cc: Dave Airlie <airlied@linux.ie>
>> ---
>> drivers/gpu/drm/rcar-du/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> --- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig
>> +++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig
>> @@ -24,6 +24,7 @@ config DRM_RCAR_CMM
>> config DRM_RCAR_DW_HDMI
>> tristate "R-Car DU Gen3 HDMI Encoder Support"
>> depends on DRM && OF
>> + depends on DRM_RCAR_DU
>> select DRM_DW_HDMI
>> help
>> Enable support for R-Car Gen3 internal HDMI encoder.
>> @@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI
>> config DRM_RCAR_LVDS
>> tristate "R-Car DU LVDS Encoder Support"
>> depends on DRM && DRM_BRIDGE && OF
>> + depends on DRM_RCAR_DU
>> select DRM_PANEL
>> select OF_FLATTREE
>> select OF_OVERLAY
>> @@ -47,4 +49,5 @@ config DRM_RCAR_VSP
>>
>> config DRM_RCAR_WRITEBACK
>> bool
>> + depends on DRM_RCAR_DU
>> default y if ARM64
>
> Is this one needed ? The symbol should not be shown in the kconfig menu
> as it has no text.
Hi Laurent,
I tried the patch without that line as my first attempt and there was
still a problem with the menu, so I will resubmit the patch using a block
as Geert suggested.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-06 15:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 3:17 [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU Randy Dunlap
2020-03-06 8:00 ` Geert Uytterhoeven
2020-03-06 14:28 ` Laurent Pinchart
2020-03-06 15:09 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).