* [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA
@ 2016-01-23 15:31 Masahiro Yamada
2016-01-23 17:56 ` kbuild test robot
2016-01-28 10:24 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Masahiro Yamada @ 2016-01-23 15:31 UTC (permalink / raw)
To: linux-gpio; +Cc: Robert Jarzmik, Masahiro Yamada, Linus Walleij, linux-kernel
CONFIG_PINCTRL_PXA is more suitable than CONFIG_ARCH_PXA
to guard the drivers/pinctrl/pxa/ directory.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/pinctrl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index b7b456a..04b633f 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -40,7 +40,7 @@ obj-y += freescale/
obj-$(CONFIG_X86) += intel/
obj-$(CONFIG_PINCTRL_MVEBU) += mvebu/
obj-y += nomadik/
-obj-$(CONFIG_ARCH_PXA) += pxa/
+obj-$(CONFIG_PINCTRL_PXA) += pxa/
obj-$(CONFIG_ARCH_QCOM) += qcom/
obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/
obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc/
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA
2016-01-23 15:31 [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA Masahiro Yamada
@ 2016-01-23 17:56 ` kbuild test robot
2016-01-23 19:35 ` Masahiro Yamada
2016-01-28 10:24 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2016-01-23 17:56 UTC (permalink / raw)
To: Masahiro Yamada
Cc: kbuild-all, linux-gpio, Robert Jarzmik, Masahiro Yamada,
Linus Walleij, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
Hi Masahiro,
[auto build test ERROR on next-20160122]
[cannot apply to v4.4-rc8 v4.4-rc7 v4.4-rc6 v4.4]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/pinctrl-pxa-guard-sub-directory-with-CONFIG_PINCTRL_PXA/20160123-233501
config: x86_64-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 53158 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA
2016-01-23 17:56 ` kbuild test robot
@ 2016-01-23 19:35 ` Masahiro Yamada
2016-01-23 22:22 ` Robert Jarzmik
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2016-01-23 19:35 UTC (permalink / raw)
To: linux-gpio; +Cc: Robert Jarzmik, Linux Kernel Mailing List, Linus Walleij
2016-01-24 2:56 GMT+09:00 kbuild test robot <lkp@intel.com>:
> Hi Masahiro,
>
> [auto build test ERROR on next-20160122]
> [cannot apply to v4.4-rc8 v4.4-rc7 v4.4-rc6 v4.4]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/pinctrl-pxa-guard-sub-directory-with-CONFIG_PINCTRL_PXA/20160123-233501
> config: x86_64-allmodconfig (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
>>> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
driver/pinctrl/pxa/ has never been compile-tested before,
and it has just unveiled some issues of this driver.
[1] driver/pinctrl/pxa/ has not been activated yet,
so I posted this:
https://patchwork.kernel.org/patch/8097771/
[2] this driver is declared as tristate, but it cannot be a module,
so I posted this:
https://patchwork.kernel.org/patch/8097781/
I hope [2] will be applied before this patch
in order to suppress the complaint by the kbuild test robot.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA
2016-01-23 19:35 ` Masahiro Yamada
@ 2016-01-23 22:22 ` Robert Jarzmik
0 siblings, 0 replies; 5+ messages in thread
From: Robert Jarzmik @ 2016-01-23 22:22 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-gpio, Linux Kernel Mailing List, Linus Walleij
Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> 2016-01-24 2:56 GMT+09:00 kbuild test robot <lkp@intel.com>:
>> Hi Masahiro,
>>
>> [auto build test ERROR on next-20160122]
>> [cannot apply to v4.4-rc8 v4.4-rc7 v4.4-rc6 v4.4]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>>
>> url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/pinctrl-pxa-guard-sub-directory-with-CONFIG_PINCTRL_PXA/20160123-233501
>> config: x86_64-allmodconfig (attached as .config)
>> reproduce:
>> # save the attached .config to linux build tree
>> make ARCH=x86_64
>>
>> All errors (new ones prefixed by >>):
>>
>>>> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
>
> driver/pinctrl/pxa/ has never been compile-tested before,
It was, and runtime tested also, in a builtin form. It was not activated in the
kernel at the arch/arm pxa architecture level would be a better statement.
> [2] this driver is declared as tristate, but it cannot be a module,
> so I posted this:
> https://patchwork.kernel.org/patch/8097781/
Yes this certainly is a bug.
> I hope [2] will be applied before this patch
> in order to suppress the complaint by the kbuild test robot.
Let's see what Linus thinks of it.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA
2016-01-23 15:31 [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA Masahiro Yamada
2016-01-23 17:56 ` kbuild test robot
@ 2016-01-28 10:24 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-01-28 10:24 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-gpio, Robert Jarzmik, linux-kernel
On Sat, Jan 23, 2016 at 4:31 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> CONFIG_PINCTRL_PXA is more suitable than CONFIG_ARCH_PXA
> to guard the drivers/pinctrl/pxa/ directory.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-28 10:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-23 15:31 [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA Masahiro Yamada
2016-01-23 17:56 ` kbuild test robot
2016-01-23 19:35 ` Masahiro Yamada
2016-01-23 22:22 ` Robert Jarzmik
2016-01-28 10:24 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).