[linuxppc:next-test 75/91] arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window'

[linuxppc:next-test 75/91] arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window'

[kernel test robot]

tree:   https://github.com/linuxppc/linux next-test
head:   1d8abffc14aef88bfe1ad036084070af62f30c03
commit: 34fa52eec206db38399dc9b54f2da2eed4fdad5e [75/91] powerpc: Remove asm/prom.h from all files that don't need it
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220506/202205061138.zH9VucCL-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/linuxppc/linux/commit/34fa52eec206db38399dc9b54f2da2eed4fdad5e
        git remote add linuxppc https://github.com/linuxppc/linux
        git fetch --no-tags linuxppc next-test
        git checkout 34fa52eec206db38399dc9b54f2da2eed4fdad5e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window' [-Wmissing-prototypes]
      10 | void of_parse_dma_window(struct device_node *dn, const __be32 *dma_window,
         |      ^~~~~~~~~~~~~~~~~~~


vim +/of_parse_dma_window +10 arch/powerpc/kernel/prom_parse.c

83efafb301bc79 Andy Fleming    2006-10-16   9  
2083f681e38983 Anton Blanchard 2013-08-07 @10  void of_parse_dma_window(struct device_node *dn, const __be32 *dma_window,

:::::: The code at line 10 was first introduced by commit
:::::: 2083f681e3898394dcf5fb3285bb385e21facb9a powerpc: of_parse_dma_window should take a __be32 *dma_window

:::::: TO: Anton Blanchard <anton@samba.org>
:::::: CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [linuxppc:next-test 75/91] arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window'

[Christophe Leroy]

Le 06/05/2022 à 05:46, kernel test robot a écrit :
> tree:   https://github.com/linuxppc/linux next-test
> head:   1d8abffc14aef88bfe1ad036084070af62f30c03
> commit: 34fa52eec206db38399dc9b54f2da2eed4fdad5e [75/91] powerpc: Remove asm/prom.h from all files that don't need it
> config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220506/202205061138.zH9VucCL-lkp@intel.com/config)
> compiler: powerpc-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/linuxppc/linux/commit/34fa52eec206db38399dc9b54f2da2eed4fdad5e
>          git remote add linuxppc https://github.com/linuxppc/linux
>          git fetch --no-tags linuxppc next-test
>          git checkout 34fa52eec206db38399dc9b54f2da2eed4fdad5e
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>>> arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window' [-Wmissing-prototypes]
>        10 | void of_parse_dma_window(struct device_node *dn, const __be32 *dma_window,
>           |      ^~~~~~~~~~~~~~~~~~~
> 
> 

Ok, so asm/prom.h must remain in arch/powerpc/kernel/prom_parse.c to get 
of_parse_dma_window() prototype.

Michael, can you drop the hunk when applying ?

Thanks
Christophe

Re: [linuxppc:next-test 75/91] arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window'

[Michael Ellerman]

Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 06/05/2022 à 05:46, kernel test robot a écrit :
>> tree:   https://github.com/linuxppc/linux next-test
>> head:   1d8abffc14aef88bfe1ad036084070af62f30c03
>> commit: 34fa52eec206db38399dc9b54f2da2eed4fdad5e [75/91] powerpc: Remove asm/prom.h from all files that don't need it
>> config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220506/202205061138.zH9VucCL-lkp@intel.com/config)
>> compiler: powerpc-linux-gcc (GCC) 11.3.0
>> reproduce (this is a W=1 build):
>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          # https://github.com/linuxppc/linux/commit/34fa52eec206db38399dc9b54f2da2eed4fdad5e
>>          git remote add linuxppc https://github.com/linuxppc/linux
>>          git fetch --no-tags linuxppc next-test
>>          git checkout 34fa52eec206db38399dc9b54f2da2eed4fdad5e
>>          # save the config file
>>          mkdir build_dir && cp config build_dir/.config
>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> arch/powerpc/kernel/prom_parse.c:10:6: warning: no previous prototype for 'of_parse_dma_window' [-Wmissing-prototypes]
>>        10 | void of_parse_dma_window(struct device_node *dn, const __be32 *dma_window,
>>           |      ^~~~~~~~~~~~~~~~~~~
>>
>>
>
> Ok, so asm/prom.h must remain in arch/powerpc/kernel/prom_parse.c to get
> of_parse_dma_window() prototype.
>
> Michael, can you drop the hunk when applying ?

Yep, done.

cheers