From: Michael Ellerman <mpe@ellerman.id.au>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: install is no longer PHONY?
Date: Mon, 17 Feb 2020 21:28:55 +1100 [thread overview]
Message-ID: <87d0adfqxk.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <CAK7LNASePHZ78O6fnScU_fVHkDOKJEgT+B+OC7NPxkW+tb7q1Q@mail.gmail.com>
Masahiro Yamada <masahiroy@kernel.org> writes:
> Hi Michael,
>
> On Mon, Feb 10, 2020 at 2:15 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Hi Masahiro,
>>
>> I noticed that "install" seems to be no longer PHONY, or at least if I
>> have a file/directory called install then the build doesn't run.
>>
>> eg:
>> $ touch install
>> $ make install
>> make: 'install' is up to date.
>> $ rm install
>> $ make install
>> LDS arch/powerpc/boot/zImage.lds
>> WRAP arch/powerpc/boot/zImage.pseries
>> WRAP arch/powerpc/boot/zImage.epapr
>
>
> I think the reason is
> 'install' is not specified as a phony target.
>
> You can add 'PHONY += install' to fix it.
>
>
> PHONY += install # please add this!
> install:
> $(Q)$(MAKE) $(build)=$(boot) install
>
>
> Please do so in both arch/powerpc/Makefile and
> arch/powerpc/boot/Makefile.
Oh lol, sorry I didn't realise install was in the arch Makefile.
>> In the past the presence of an install file/directory didn't have any
>> affect.
>>
>> It seems this changed in:
>> d79424137a73 ("kbuild: do not update config when running install targets")
>>
>> Was that expected?
>>
>> cheers
>
>
> I do not think commit is related.
>
> Prior to this commit, I still see the same issue.
>
>
> $ git checkout d7942413^
> $ touch install
> $ make -s ARCH=powerpc allnoconfig
> $ make ARCH=powerpc install
> make: 'install' is up to date.
Hmm weird. I did bisect it:
# bad: [d79424137a7312d381d131d707a462440c0e8df9] kbuild: do not update config when running install targets
git bisect bad d79424137a7312d381d131d707a462440c0e8df9
# good: [9c2af1c7377a8a6ef86e5cabf80978f3dbbb25c0] kbuild: add .DELETE_ON_ERROR special target
git bisect good 9c2af1c7377a8a6ef86e5cabf80978f3dbbb25c0
# first bad commit: [d79424137a7312d381d131d707a462440c0e8df9] kbuild: do not update config when running install targets
But you're right. I must have messed something up while bisecting.
Sorry for the noise.
cheers
prev parent reply other threads:[~2020-02-17 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 5:14 install is no longer PHONY? Michael Ellerman
2020-02-13 16:32 ` Masahiro Yamada
2020-02-17 10:28 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0adfqxk.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).