From: Eric Anholt <eric@anholt.net>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: open list <linux-kernel@vger.kernel.org>,
Will Deacon <will.deacon@arm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/9] arm64: Add platform selection for BCM2835.
Date: Tue, 14 Jun 2016 23:48:54 -0700 [thread overview]
Message-ID: <87d1njq755.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20160610095633.GA14961@e104818-lin.cambridge.arm.com>
[-- Attachment #1: Type: text/plain, Size: 2136 bytes --]
Catalin Marinas <catalin.marinas@arm.com> writes:
> On Thu, Jun 09, 2016 at 05:21:35PM -0700, Eric Anholt wrote:
>> Catalin Marinas <catalin.marinas@arm.com> writes:
>> > On Sat, Jun 04, 2016 at 12:55:15PM -0700, Eric Anholt wrote:
>> >> Catalin Marinas <catalin.marinas@arm.com> writes:
>> >> > On Fri, Jun 03, 2016 at 08:18:23AM +0200, Gerd Hoffmann wrote:
>> >> >> + This SoC is used in the Raspberry Pi 3 device.
>> >> >
>> >> > I thought we would just use ARCH_BCM, or is it too generic?
>> >>
>> >> Consensus last time around seemed to be to drop adding ARCH_BCM, in
>> >> favor of patch 1 of the series.
>> >
>> > I may have missed that discussion. My point was about consistency with
>> > existing ARCH_* definitions in the arm64 Kconfig.platforms. I can see
>> > why it's easier for you since some drivers are built based on
>> > ARCH_BCM2835. Looking at drivers/clk/bcm/Makefile, there is an
>> > inconsistent mix of CLK_BCM_* and ARCH_BCM_*. I would rather have a new
>> > CLK_BCM2835 that's selected/enabled accordingly (maybe simply depending
>> > on ARCH_BCM).
>>
>> So I introduce a new ARCH_BCM here, that selects the just the 283x
>> family's core drivers? That seems strange, but I'm willing if that's
>> what you want.
>
> I'll leave this decision to the arm-soc guys. What I want to avoid is
> another ARCH_BCM283[89] when some clock or other device changes in a
> future revision of this board (RPi4?). I also don't want fine-grained
> SoC configuration *within* the arch/arm64 Kconfigs but rather just a
> family ARCH_* entry with selectable individual drivers based on the SoC
> revision you target (in case you want to avoid single Image).
>
> We should in general try to give drivers their own Kconfig entries
> separate from ARCH_* ones (with a "depend on ARCH_*" and default y if
> you want it enabled).
OK, we haven't added separate ARCH_BCM283* for the 3 chip revs so far,
so I think what you want is actually the status quo, and we're in
serious agreement. The name for the family just happens to be
ARCH_BCM2835.
Any chance we could get an ack on this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-06-15 6:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1464934708-24769-1-git-send-email-kraxel@redhat.com>
2016-06-03 6:18 ` [PATCH v2 1/9] pinctrl: walk into bcm subdir unconditionally Gerd Hoffmann
2016-06-08 8:12 ` Linus Walleij
2016-06-10 0:16 ` Eric Anholt
2016-06-13 7:26 ` Linus Walleij
2016-06-14 17:37 ` Eric Anholt
2016-06-03 6:18 ` [PATCH v2 2/9] irqchip: bcm2835: Avoid arch/arm-specific handle_IRQ Gerd Hoffmann
2016-06-03 6:18 ` [PATCH v2 3/9] arm64: Allow for different DMA and CPU bus offsets Gerd Hoffmann
2016-06-03 6:18 ` [PATCH v2 4/9] arm64: Add platform selection for BCM2835 Gerd Hoffmann
2016-06-03 11:27 ` Catalin Marinas
2016-06-04 19:55 ` Eric Anholt
2016-06-08 9:12 ` Catalin Marinas
2016-06-10 0:21 ` Eric Anholt
2016-06-10 9:56 ` Catalin Marinas
2016-06-15 6:48 ` Eric Anholt [this message]
2016-06-15 8:07 ` Catalin Marinas
2016-06-15 21:57 ` Eric Anholt
2016-06-03 6:18 ` [PATCH v2 5/9] arm64: Add BCM2835 support to the defconfig Gerd Hoffmann
2016-06-03 7:36 ` Arnd Bergmann
2016-06-03 8:50 ` Gerd Hoffmann
2016-06-03 8:58 ` Arnd Bergmann
2016-06-03 9:53 ` Gerd Hoffmann
2016-06-07 22:16 ` Eric Anholt
2016-06-03 6:18 ` [PATCH v2 6/9] dt-bindings: Add root properties for Raspberry Pi 3 Gerd Hoffmann
2016-06-03 6:18 ` [PATCH v2 7/9] ARM: bcm2835: Add devicetree for the " Gerd Hoffmann
2016-06-03 7:38 ` Arnd Bergmann
2016-06-03 8:45 ` Gerd Hoffmann
2016-06-03 8:55 ` Arnd Bergmann
2016-06-03 10:39 ` Gerd Hoffmann
2016-06-03 11:15 ` Arnd Bergmann
2016-06-03 16:17 ` Rob Herring
2016-06-04 21:39 ` Arnd Bergmann
2016-06-06 7:20 ` Gerd Hoffmann
2016-06-06 7:28 ` Arnd Bergmann
2016-06-06 7:47 ` Gerd Hoffmann
2016-06-03 9:04 ` Stefan Wahren
2016-06-03 6:18 ` [PATCH v2 8/9] ARM: bcm2835: dt: Add the ethernet to the device trees Gerd Hoffmann
2016-06-03 6:18 ` [PATCH v2 9/9] ARM: bcm2837: " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1njq755.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=catalin.marinas@arm.com \
--cc=kraxel@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).