linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	linux-rpi-kernel@lists.infradead.org,
	Eric Anholt <eric@anholt.net>, Will Deacon <will.deacon@arm.com>,
	open list <linux-kernel@vger.kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v2 5/9] arm64: Add BCM2835 support to the defconfig.
Date: Fri, 03 Jun 2016 09:36:03 +0200	[thread overview]
Message-ID: <3299125.qWct7BqQgQ@wuerfel> (raw)
In-Reply-To: <1464934708-24769-6-git-send-email-kraxel@redhat.com>

On Friday, June 3, 2016 8:18:24 AM CEST Gerd Hoffmann wrote:
> From: Eric Anholt <eric@anholt.net>
> 
> Made with make defconfig; make menuconfig (only saying Y to new
> entries); make savedefconfig.

Please try not to mix 'make savedefconfig' changes with your
own changes, it make it harder to review and can lead to more
conflicts.

> @@ -140,6 +141,9 @@ CONFIG_USB_NET_PLUSB=m
>  CONFIG_USB_NET_MCS7830=m
>  CONFIG_WL18XX=m
>  CONFIG_WLCORE_SDIO=m
> +CONFIG_USB_USBNET=y
> +CONFIG_USB_NET_SMSC95XX=y
> +# CONFIG_WLAN is not set
>  CONFIG_INPUT_EVDEV=y
>  CONFIG_KEYBOARD_GPIO=y

Can this be =m like the others?

> -CONFIG_FB=y
> -CONFIG_FRAMEBUFFER_CONSOLE=y

Is this intended?

> +CONFIG_DRM=y
> +CONFIG_DRM_VC4=y
>  CONFIG_FB_ARMCLCD=y
>  CONFIG_LOGO=y

Maybe modules?


>  # CONFIG_LOGO_LINUX_MONO is not set
>  # CONFIG_LOGO_LINUX_VGA16 is not set
>  CONFIG_SOUND=y
>  CONFIG_SND=y
>  CONFIG_SND_SOC=y
> +CONFIG_SND_BCM2835_SOC_I2S=y
>  CONFIG_SND_SOC_RCAR=y
>  CONFIG_SND_SOC_AK4613=y
>  CONFIG_USB=y

We probably want CONFIG_SND=m, but that should be a separate patch.

> @@ -270,6 +284,7 @@ CONFIG_RTC_DRV_SUN6I=y
>  CONFIG_RTC_DRV_XGENE=y
>  CONFIG_DMADEVICES=y
>  CONFIG_PL330_DMA=y
> +CONFIG_DMA_BCM2835=y
>  CONFIG_TEGRA20_APB_DMA=y
>  CONFIG_QCOM_BAM_DMA=y
>  CONFIG_RCAR_DMAC=y

Does any essential driver depend on this one?

> @@ -311,7 +329,6 @@ CONFIG_AUTOFS4_FS=y
>  CONFIG_FUSE_FS=y
>  CONFIG_CUSE=y
>  CONFIG_VFAT_FS=y
> -CONFIG_TMPFS=y
>  CONFIG_HUGETLBFS=y
>  CONFIG_CONFIGFS_FS=y
>  CONFIG_EFIVAR_FS=y

Why?

	Arnd

  reply	other threads:[~2016-06-03  7:39 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1464934708-24769-1-git-send-email-kraxel@redhat.com>
2016-06-03  6:18 ` [PATCH v2 1/9] pinctrl: walk into bcm subdir unconditionally Gerd Hoffmann
2016-06-08  8:12   ` Linus Walleij
2016-06-10  0:16     ` Eric Anholt
2016-06-13  7:26   ` Linus Walleij
2016-06-14 17:37     ` Eric Anholt
2016-06-03  6:18 ` [PATCH v2 2/9] irqchip: bcm2835: Avoid arch/arm-specific handle_IRQ Gerd Hoffmann
2016-06-03  6:18 ` [PATCH v2 3/9] arm64: Allow for different DMA and CPU bus offsets Gerd Hoffmann
2016-06-03  6:18 ` [PATCH v2 4/9] arm64: Add platform selection for BCM2835 Gerd Hoffmann
2016-06-03 11:27   ` Catalin Marinas
2016-06-04 19:55     ` Eric Anholt
2016-06-08  9:12       ` Catalin Marinas
2016-06-10  0:21         ` Eric Anholt
2016-06-10  9:56           ` Catalin Marinas
2016-06-15  6:48             ` Eric Anholt
2016-06-15  8:07               ` Catalin Marinas
2016-06-15 21:57                 ` Eric Anholt
2016-06-03  6:18 ` [PATCH v2 5/9] arm64: Add BCM2835 support to the defconfig Gerd Hoffmann
2016-06-03  7:36   ` Arnd Bergmann [this message]
2016-06-03  8:50     ` Gerd Hoffmann
2016-06-03  8:58       ` Arnd Bergmann
2016-06-03  9:53     ` Gerd Hoffmann
2016-06-07 22:16     ` Eric Anholt
2016-06-03  6:18 ` [PATCH v2 6/9] dt-bindings: Add root properties for Raspberry Pi 3 Gerd Hoffmann
2016-06-03  6:18 ` [PATCH v2 7/9] ARM: bcm2835: Add devicetree for the " Gerd Hoffmann
2016-06-03  7:38   ` Arnd Bergmann
2016-06-03  8:45     ` Gerd Hoffmann
2016-06-03  8:55       ` Arnd Bergmann
2016-06-03 10:39         ` Gerd Hoffmann
2016-06-03 11:15           ` Arnd Bergmann
2016-06-03 16:17           ` Rob Herring
2016-06-04 21:39             ` Arnd Bergmann
2016-06-06  7:20             ` Gerd Hoffmann
2016-06-06  7:28               ` Arnd Bergmann
2016-06-06  7:47                 ` Gerd Hoffmann
2016-06-03  9:04   ` Stefan Wahren
2016-06-03  6:18 ` [PATCH v2 8/9] ARM: bcm2835: dt: Add the ethernet to the device trees Gerd Hoffmann
2016-06-03  6:18 ` [PATCH v2 9/9] ARM: bcm2837: " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3299125.qWct7BqQgQ@wuerfel \
    --to=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=eric@anholt.net \
    --cc=kraxel@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).