* [PATCH -next] virtio_console: make local symbols static
@ 2013-04-06 3:52 Wei Yongjun
2013-04-08 5:53 ` Amit Shah
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-04-06 3:52 UTC (permalink / raw)
To: amit.shah, arnd, rusty, gregkh; +Cc: yongjun_wei, virtualization, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Those symbols only used within this file, and should be static.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/char/virtio_console.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 13ad9b1..f73ad64 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -78,8 +78,8 @@ struct ports_driver_data {
};
static struct ports_driver_data pdrvdata;
-DEFINE_SPINLOCK(pdrvdata_lock);
-DECLARE_COMPLETION(early_console_added);
+static DEFINE_SPINLOCK(pdrvdata_lock);
+static DECLARE_COMPLETION(early_console_added);
/* This struct holds information that's relevant only for console ports */
struct console {
@@ -1202,7 +1202,7 @@ int __init virtio_cons_early_init(int (*put_chars)(u32, const char *, int))
return hvc_instantiate(0, 0, &hv_ops);
}
-int init_port_console(struct port *port)
+static int init_port_console(struct port *port)
{
int ret;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] virtio_console: make local symbols static
2013-04-06 3:52 [PATCH -next] virtio_console: make local symbols static Wei Yongjun
@ 2013-04-08 5:53 ` Amit Shah
2013-04-08 13:28 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Amit Shah @ 2013-04-08 5:53 UTC (permalink / raw)
To: Wei Yongjun
Cc: arnd, rusty, gregkh, yongjun_wei, virtualization, linux-kernel
On (Sat) 06 Apr 2013 [11:52:07], Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Those symbols only used within this file, and should be static.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Amit Shah <amit.shah@redhat.com>
Amit
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] virtio_console: make local symbols static
2013-04-08 5:53 ` Amit Shah
@ 2013-04-08 13:28 ` Rusty Russell
0 siblings, 0 replies; 3+ messages in thread
From: Rusty Russell @ 2013-04-08 13:28 UTC (permalink / raw)
To: Amit Shah, Wei Yongjun
Cc: arnd, gregkh, yongjun_wei, virtualization, linux-kernel
Amit Shah <amit.shah@redhat.com> writes:
> On (Sat) 06 Apr 2013 [11:52:07], Wei Yongjun wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Those symbols only used within this file, and should be static.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Amit Shah <amit.shah@redhat.com>
>
> Amit
Thanks, applied.
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-08 14:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-06 3:52 [PATCH -next] virtio_console: make local symbols static Wei Yongjun
2013-04-08 5:53 ` Amit Shah
2013-04-08 13:28 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).