* [PATCH] qmi_wwan: add support for Quectel EG91
@ 2018-07-04 14:40 Matevz Vucnik
2018-07-04 14:55 ` Bjørn Mork
0 siblings, 1 reply; 3+ messages in thread
From: Matevz Vucnik @ 2018-07-04 14:40 UTC (permalink / raw)
To: bjorn; +Cc: davem, netdev, linux-usb, linux-kernel, Matevz Vucnik
This adds the USB id of LTE modem Quectel EG91. It requires the
same quirk as other Quectel modems to make it work.
Signed-off-by: Matevz Vucnik <vucnikm@gmail.com>
---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 8fac8e1..829c05b 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1255,6 +1255,7 @@ static const struct usb_device_id products[] = {
{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
{QMI_QUIRK_SET_DTR(0x2c7c, 0x0306, 4)}, /* Quectel EP06 Mini PCIe */
+ {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */
/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qmi_wwan: add support for Quectel EG91
2018-07-04 14:40 [PATCH] qmi_wwan: add support for Quectel EG91 Matevz Vucnik
@ 2018-07-04 14:55 ` Bjørn Mork
[not found] ` <CAJRueBROA936kdgmH3kwp0X4CD=Y+KJ7_iqzuZ8dJqidBRzYiA@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Bjørn Mork @ 2018-07-04 14:55 UTC (permalink / raw)
To: Matevz Vucnik; +Cc: davem, netdev, linux-usb, linux-kernel
On July 4, 2018 4:40:05 PM GMT+02:00, Matevz Vucnik <vucnikm@gmail.com> wrote:
>This adds the USB id of LTE modem Quectel EG91. It requires the
>same quirk as other Quectel modems to make it work.
>
>Signed-off-by: Matevz Vucnik <vucnikm@gmail.com>
>---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>index 8fac8e1..829c05b 100644
>--- a/drivers/net/usb/qmi_wwan.c
>+++ b/drivers/net/usb/qmi_wwan.c
>@@ -1255,6 +1255,7 @@ static const struct usb_device_id products[] = {
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
> {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0306, 4)}, /* Quectel EP06 Mini PCIe */
>+ {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */
>
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
I know it's not perfect before, but can we try to keep new entries in numerical order?
Thanks
Bjørn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qmi_wwan: add support for Quectel EG91
[not found] ` <CAJRueBROA936kdgmH3kwp0X4CD=Y+KJ7_iqzuZ8dJqidBRzYiA@mail.gmail.com>
@ 2018-07-04 15:56 ` Bjørn Mork
0 siblings, 0 replies; 3+ messages in thread
From: Bjørn Mork @ 2018-07-04 15:56 UTC (permalink / raw)
To: Matevž Vučnik; +Cc: davem, netdev, linux-usb, linux-kernel
Matevž Vučnik <vucnikm@gmail.com> writes:
> Sorry, I missed this one. It's a good idea to keep numerical order. Is it ok
> to fix it and send a new patch?
Yes, sure. Just label it as v2 or similar to make it clear that it's a
new version of the same patch.
Bjørn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-04 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04 14:40 [PATCH] qmi_wwan: add support for Quectel EG91 Matevz Vucnik
2018-07-04 14:55 ` Bjørn Mork
[not found] ` <CAJRueBROA936kdgmH3kwp0X4CD=Y+KJ7_iqzuZ8dJqidBRzYiA@mail.gmail.com>
2018-07-04 15:56 ` Bjørn Mork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).