* [PATCH] powerpc/mm: Move page table dump into powerpc subdirectory
@ 2017-04-13 12:41 Christophe Leroy
2017-04-13 13:20 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Christophe Leroy @ 2017-04-13 12:41 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Scott Wood, Rashmica Gupta
Cc: linux-kernel, linuxppc-dev
Page table dump is a powerpc specific thing, so it should
appear in powerpc/ subdirectory of debugfs
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
arch/powerpc/mm/dump_linuxpagetables.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/mm/dump_linuxpagetables.c b/arch/powerpc/mm/dump_linuxpagetables.c
index 22d2433333f5..df7664ea7ede 100644
--- a/arch/powerpc/mm/dump_linuxpagetables.c
+++ b/arch/powerpc/mm/dump_linuxpagetables.c
@@ -14,7 +14,7 @@
* as published by the Free Software Foundation; version 2
* of the License.
*/
-#include <linux/debugfs.h>
+#include <asm/debugfs.h>
#include <linux/fs.h>
#include <linux/io.h>
#include <linux/mm.h>
@@ -483,8 +483,8 @@ static int ptdump_init(void)
populate_markers();
build_pgtable_complete_mask();
- debugfs_file = debugfs_create_file("kernel_pagetables", 0400, NULL,
- NULL, &ptdump_fops);
+ debugfs_file = debugfs_create_file("kernel_pagetables", 0400,
+ powerpc_debugfs_root, NULL, &ptdump_fops);
return debugfs_file ? 0 : -ENOMEM;
}
device_initcall(ptdump_init);
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/mm: Move page table dump into powerpc subdirectory
2017-04-13 12:41 [PATCH] powerpc/mm: Move page table dump into powerpc subdirectory Christophe Leroy
@ 2017-04-13 13:20 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2017-04-13 13:20 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras,
Scott Wood, Rashmica Gupta
Cc: linux-kernel, linuxppc-dev
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Page table dump is a powerpc specific thing, so it should
> appear in powerpc/ subdirectory of debugfs
It's not powerpc specific. x86, arm, arm64 and s390 all have it.
But, I notice we somehow got the name wrong :}
All the other arches call it "kernel_page_tables".
> - debugfs_file = debugfs_create_file("kernel_pagetables", 0400, NULL,
> - NULL, &ptdump_fops);
¯\_(ツ)_/¯
So we probably should rename it to match the other arches. I would take
a patch for that.
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-13 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 12:41 [PATCH] powerpc/mm: Move page table dump into powerpc subdirectory Christophe Leroy
2017-04-13 13:20 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).