From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: John Youn <John.Youn@synopsys.com>,
Randy Li <randy.li@rock-chips.com>,
John Youn <John.Youn@synopsys.com>, Randy Li <ayaka@soulik.info>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: "mark.rutland\@arm.com" <mark.rutland@arm.com>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
"heiko\@sntech.de" <heiko@sntech.de>,
"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rockchip\@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"robh+dt\@kernel.org" <robh+dt@kernel.org>,
"eddie.cai\@rock-chips.com" <eddie.cai@rock-chips.com>,
"kishon\@ti.com" <kishon@ti.com>
Subject: Re: [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform
Date: Mon, 29 Aug 2016 10:51:15 +0300 [thread overview]
Message-ID: <87fupodnd8.fsf@linux.intel.com> (raw)
In-Reply-To: <f6bbd88b-5d80-c30d-36c1-5b95763ae4bb@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
Hi,
John Youn <John.Youn@synopsys.com> writes:
[...]
>>>> + */
>>>> + if (of_device_is_compatible(np, "rockchip,rk3288-usb"))
>>>> + hsotg->phy->ops->reset(hsotg->phy);
>>>> +
>>>
>>> You should probably check for NULL before calling the reset()
>>> callback.
>> Sure.
>>>
>>> Also, I'd rather see a generic quirk property that you set for your
>>> platform.
>>>
>>> Something like "phy_reset_on_wakeup_quirk".
>> But Rob Herring want me to implied by the SoC specific compatible
>> string. I agree with him. It is certainly bug in RK3288 platform.
>> It is no found no the other platform.
>
> Ok, I missed that before.
>
> Based on the drivers I'm familiar with (like dwc3), you would
> typically add a "quirk" anyways.
>
> Felipe,
>
> Do you have some policy or preference on this?
if it's not a dwc2-generic feature, then let's do it via compatible
flag, sure. What we don't want is for things like:
if (is_compatible('synopsys') || is_compatible('rockchip') ||
is_compatible('foobar') ... )
For that, we'd be better of adding a generic quirk flag which several
can use.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-08-29 7:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7ca3b54d-e9d8-a137-79b6-d24f0b7065c7@synopsys.com>
2016-08-20 20:32 ` [PATCH 0/4 v4] usb: dwc2: fix the usb host for host port at RK32 Randy Li
2016-08-20 20:32 ` [PATCH 1/4] phy: Add reset callback Randy Li
2016-08-20 20:32 ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-08-22 11:47 ` Kishon Vijay Abraham I
2016-08-22 13:00 ` Heiko Stübner
2016-08-29 9:32 ` Kishon Vijay Abraham I
2016-08-20 20:32 ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-20 21:30 ` Sergei Shtylyov
2016-08-21 7:56 ` [PATCH 0/4 v5] usb: dwc2: fix the usb host for host port at RK32 Randy Li
2016-08-21 7:56 ` [PATCH 1/4] phy: Add reset callback Randy Li
2016-08-21 7:56 ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-08-23 17:53 ` Rob Herring
2016-08-21 7:56 ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-21 7:56 ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-08-21 11:06 ` Sergei Shtylyov
2016-08-21 12:19 ` ayaka
2016-08-22 10:30 ` Sergei Shtylyov
2016-08-21 19:31 ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-21 19:31 ` [RESEND PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-08-23 20:46 ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform John Youn
2016-08-24 8:54 ` Randy Li
2016-08-25 18:23 ` John Youn
2016-08-29 7:51 ` Felipe Balbi [this message]
2016-08-29 18:24 ` John Youn
2016-08-20 20:32 ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fupodnd8.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=John.Youn@synopsys.com \
--cc=ayaka@soulik.info \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=randy.li@rock-chips.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).