From: ayaka <ayaka@soulik.info>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-usb@vger.kernel.org
Cc: johnyoun@synopsys.com, gregkh@linuxfoundation.org,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, eddie.cai@rock-chips.com,
randy.li@rock-chips.com, kishon@ti.com,
linux-kernel@vger.kernel.org, heiko@sntech.de,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset
Date: Sun, 21 Aug 2016 20:19:40 +0800 [thread overview]
Message-ID: <b60bcef2-31d7-5a15-a09a-b71006c99c92@soulik.info> (raw)
In-Reply-To: <95d6e178-b9c5-ed40-2adc-5ffd1d78db07@cogentembedded.com>
On 08/21/2016 07:06 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 8/21/2016 10:56 AM, Randy Li wrote:
>
>> The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288
>> has a hardware errata that causes everything to get confused when we get
>> a remote wakeup. We'll use the reset that's in the CRU to reset the
>> port when it's in a bad state.
>>
>> Note that we add the reset to both dwc2 controllers even though only one
>> has the errata in case we find some other use for this reset that's
>> unrelated to the current hardware errata. Only the host port gets the
>> quirk property, though.
>>
>> This patch came from Doug Anderson <dianders@chromium.org> originally.
>
> Was it signed off by him? Don't you need to keep his authorship via
> th "From:" tag?
I would rather the idea comes from him, but the implementation is
different. I don't which tag would be
better? If the "From:" would be the best choice. I would resend the last
two patches.
>> Signed-off-by: Randy Li <ayaka@soulik.info>
>> ---
>> arch/arm/boot/dts/rk3288.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi
>> b/arch/arm/boot/dts/rk3288.dtsi
>> index 48ca4e4..646f49d 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
> [...]
>> @@ -871,6 +873,9 @@
>> clocks = <&cru SCLK_OTGPHY2>;
>> clock-names = "phyclk";
>> #clock-cells = <0>;
>> + resets = <&cru SRST_USBHOST1_PHY>;
>> + reset-names = "phy-reset";
>> +
>
> Don't need empty line here.
I would be removed
>
>> };
>> };
>> };
>
> MBR , Sergei
next prev parent reply other threads:[~2016-08-21 12:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7ca3b54d-e9d8-a137-79b6-d24f0b7065c7@synopsys.com>
2016-08-20 20:32 ` [PATCH 0/4 v4] usb: dwc2: fix the usb host for host port at RK32 Randy Li
2016-08-20 20:32 ` [PATCH 1/4] phy: Add reset callback Randy Li
2016-08-20 20:32 ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-08-22 11:47 ` Kishon Vijay Abraham I
2016-08-22 13:00 ` Heiko Stübner
2016-08-29 9:32 ` Kishon Vijay Abraham I
2016-08-20 20:32 ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-20 21:30 ` Sergei Shtylyov
2016-08-21 7:56 ` [PATCH 0/4 v5] usb: dwc2: fix the usb host for host port at RK32 Randy Li
2016-08-21 7:56 ` [PATCH 1/4] phy: Add reset callback Randy Li
2016-08-21 7:56 ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-08-23 17:53 ` Rob Herring
2016-08-21 7:56 ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-21 7:56 ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-08-21 11:06 ` Sergei Shtylyov
2016-08-21 12:19 ` ayaka [this message]
2016-08-22 10:30 ` Sergei Shtylyov
2016-08-21 19:31 ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-21 19:31 ` [RESEND PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-08-23 20:46 ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform John Youn
2016-08-24 8:54 ` Randy Li
2016-08-25 18:23 ` John Youn
2016-08-29 7:51 ` Felipe Balbi
2016-08-29 18:24 ` John Youn
2016-08-20 20:32 ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-09-08 14:27 [PATCH 0/4] the fix for the USB HOST1 at rk3288 platform Randy Li
2016-09-08 14:27 ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b60bcef2-31d7-5a15-a09a-b71006c99c92@soulik.info \
--to=ayaka@soulik.info \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=johnyoun@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=randy.li@rock-chips.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).