* [PATCH/RFC -rt] local_bh_enable() is safe for irqs_disabled()
@ 2007-12-08 1:41 Kevin Hilman
0 siblings, 0 replies; only message in thread
From: Kevin Hilman @ 2007-12-08 1:41 UTC (permalink / raw)
To: linux-rt-users; +Cc: linux-kernel
In local_bh_enable() there is a WARN_ON(irqs_disabled()), but looking
at the rest of the code, it seems it expects to be used with
interrupts off, so is this warning really necessary?
I hit this warning in the ads7846 touchscreen driver timer function
where enable_irq() may be called with interrupts disabled. Since
enable_irq now calls local_bh_disable/enable for IRQ resend, this
warning is triggered.
Patch against 2.6.23.9-rt12
Signed-off-by: Kevin Hilman <khilman@mvista.com>
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 4c19017..68149ae 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -207,7 +207,6 @@ void local_bh_enable(void)
WARN_ON_ONCE(in_irq());
#endif
- WARN_ON_ONCE(irqs_disabled());
#ifdef CONFIG_TRACE_IRQFLAGS
local_irq_save(flags);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-12-08 1:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-08 1:41 [PATCH/RFC -rt] local_bh_enable() is safe for irqs_disabled() Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).