From: Nicolai Stange <nicstange@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Nicolai Stange <nicstange@gmail.com>,
Michal Simek <monstr@monstr.eu>,
John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks
Date: Sun, 16 Apr 2017 04:47:11 +0200 [thread overview]
Message-ID: <87h91pkr0w.fsf@gmail.com> (raw)
In-Reply-To: <20170407131429.GD2078@mai> (Daniel Lezcano's message of "Fri, 7 Apr 2017 15:14:29 +0200")
Hello Daniel,
On Fri, Apr 07 2017, Daniel Lezcano wrote:
> On Thu, Mar 30, 2017 at 09:45:28PM +0200, Nicolai Stange wrote:
>> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
>> index 999066192715..545ccd46edb3 100644
>> --- a/arch/microblaze/kernel/timer.c
>> +++ b/arch/microblaze/kernel/timer.c
>> @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void)
>> clockevent_xilinx_timer.shift);
>> clockevent_xilinx_timer.max_delta_ns =
>> clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer);
>> + clockevent_xilinx_timer.max_delta_ticks = (u32)~0;
>
> Can you take the opportunity to fix the type (unsigned long) ?
Hmm, I personally think that it'd be better to leave the u32 there as it
corresponds to the hardware's counter width?
clockevent_delta2ns()' latch argument has been of type unsigned long
from the beginning and this might indicate that at least this
driver's original author followed this line of reasoning...
OTOH, I think that u32 is equivalent to unsigned long on microblaze, so
it doesn't matter much.
Does the above convince you or do you still want the
- clockevent_xilinx_timer.max_delta_ticks = (u32)~0;
+ clockevent_xilinx_timer.max_delta_ticks = ~0UL;
change?
Thanks,
Nicolai
next prev parent reply other threads:[~2017-04-16 2:47 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 13:44 [PATCH] x86/apic/timer: set ->min_delta_ticks and ->max_delta_ticks Nicolai Stange
2017-03-30 19:39 ` [PATCH] avr32/time: " Nicolai Stange
2017-04-03 6:42 ` Hans-Christian Noren Egtvedt
2017-03-30 19:41 ` [PATCH] blackfin: time-ts: " Nicolai Stange
2017-03-30 19:42 ` [PATCH] c6x/timer64: " Nicolai Stange
2017-03-30 19:43 ` [PATCH] hexagon/time: " Nicolai Stange
2017-04-03 15:49 ` Richard Kuo
2017-03-30 19:44 ` [PATCH] m68k/coldfire/pit: " Nicolai Stange
2017-03-31 1:10 ` Greg Ungerer
2017-03-30 19:45 ` [PATCH] microblaze/timer: " Nicolai Stange
2017-04-07 13:14 ` Daniel Lezcano
2017-04-16 2:47 ` Nicolai Stange [this message]
2017-04-16 9:46 ` Daniel Lezcano
2017-05-29 9:03 ` Michal Simek
2017-03-30 19:47 ` [PATCH] MIPS: clockevent drivers: " Nicolai Stange
2017-04-12 20:10 ` Ralf Baechle
2017-03-30 19:48 ` [PATCH] mn10300/cevt-mn10300: " Nicolai Stange
2017-03-30 19:53 ` [PATCH] powerpc/time: " Nicolai Stange
2017-03-31 3:03 ` Michael Ellerman
2017-03-30 19:54 ` [PATCH] s390/time: " Nicolai Stange
2017-03-30 19:55 ` [PATCH] score/time: " Nicolai Stange
2017-03-30 19:56 ` [PATCH] sparc/time: " Nicolai Stange
2017-04-01 19:18 ` David Miller
2017-03-30 19:57 ` [PATCH] tile/time: " Nicolai Stange
2017-03-30 19:59 ` [PATCH] um/time: " Nicolai Stange
2017-03-30 20:01 ` [PATCH] unicore32/time: " Nicolai Stange
2017-03-31 1:59 ` Xuetao Guan
2017-03-30 20:03 ` [PATCH] x86/lguest/timer: " Nicolai Stange
2017-04-02 1:35 ` Rusty Russell
2017-03-30 20:04 ` [PATCH] x86/uv/time: " Nicolai Stange
2017-03-30 20:06 ` [PATCH] x86/xen/time: " Nicolai Stange
2017-03-30 22:59 ` Boris Ostrovsky
2017-04-06 9:11 ` Juergen Gross
2017-04-11 5:09 ` Juergen Gross
2017-03-30 20:07 ` [PATCH] clockevents/drivers/dw_apb: " Nicolai Stange
2017-04-07 13:20 ` Daniel Lezcano
2017-03-30 20:08 ` [PATCH] clockevents/drivers/metag: " Nicolai Stange
2017-04-07 13:20 ` Daniel Lezcano
2017-03-30 20:08 ` [PATCH] x86/numachip timer: " Nicolai Stange
2017-04-07 13:21 ` Daniel Lezcano
2017-03-30 20:09 ` [PATCH] clockevents/drivers/sh_cmt: " Nicolai Stange
2017-04-07 13:22 ` Daniel Lezcano
2017-03-30 20:10 ` [PATCH] clockevents/drivers/atlas7: " Nicolai Stange
2017-04-07 13:23 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h91pkr0w.fsf@gmail.com \
--to=nicstange@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).