From: Thomas Gleixner <tglx@linutronix.de>
To: Shuah Khan <skhan@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: "x86\@kernel.org" <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: common_interrupt: No irq handler for vector
Date: Sat, 12 Dec 2020 20:33:50 +0100 [thread overview]
Message-ID: <87im96g6ox.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <9741d93c-3cd1-c4ef-74bb-7f635231c778@linuxfoundation.org>
On Fri, Dec 11 2020 at 13:41, Shuah Khan wrote:
> I am debugging __common_interrupt: 1.55 No irq handler for vector
> messages and noticed comments and code don't agree:
I bet that's on an AMD system with broken AGESA BIOS.... Good luck
debugging it :) BIOS updates are on the way so I'm told.
> arch/x86/kernel/apic/msi.c: msi_set_affinity() says:
>
>
> * If the vector is in use then the installed device handler will
> * denote it as spurious which is no harm as this is a rare event
> * and interrupt handlers have to cope with spurious interrupts
> * anyway. If the vector is unused, then it is marked so it won't
> * trigger the 'No irq handler for vector' warning in
> * common_interrupt().
>
> common_interrupt() prints message if vector is unused: VECTOR_UNUSED
>
> ack_APIC_irq();
>
> if (desc == VECTOR_UNUSED) {
> pr_emerg_ratelimited("%s: %d.%u No irq handler for vector\n",
> __func__, smp_processor_id(), vector);
> }
>
> Something wrong here?
No. It's perfectly correct in the MSI code. See further down.
if (IS_ERR_OR_NULL(this_cpu_read(vector_irq[cfg->vector])))
this_cpu_write(vector_irq[cfg->vector], VECTOR_RETRIGGERED);
Thanks,
tglx
next prev parent reply other threads:[~2020-12-12 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 20:41 common_interrupt: No irq handler for vector Shuah Khan
2020-12-12 19:33 ` Thomas Gleixner [this message]
2020-12-14 16:11 ` Shuah Khan
2020-12-14 20:41 ` Thomas Gleixner
2020-12-14 20:50 ` Thomas Gleixner
2020-12-14 20:57 ` Shuah Khan
2020-12-14 22:28 ` Thomas Gleixner
2020-12-14 22:41 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im96g6ox.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).