From: Thomas Gleixner <tglx@linutronix.de>
To: Shuah Khan <skhan@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: "x86\@kernel.org" <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: common_interrupt: No irq handler for vector
Date: Mon, 14 Dec 2020 21:41:14 +0100 [thread overview]
Message-ID: <87lfe0dst1.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <3630fe3f-0dff-e21e-17a8-ed251df81fbc@linuxfoundation.org>
On Mon, Dec 14 2020 at 09:11, Shuah Khan wrote:
> On 12/12/20 12:33 PM, Thomas Gleixner wrote:
>> On Fri, Dec 11 2020 at 13:41, Shuah Khan wrote:
>>
>>> I am debugging __common_interrupt: 1.55 No irq handler for vector
>>> messages and noticed comments and code don't agree:
>>
>> I bet that's on an AMD system with broken AGESA BIOS.... Good luck
>> debugging it :) BIOS updates are on the way so I'm told.
>>
> Interesting. The behavior I am seeing doesn't seem to be consistent
> with BIOS problem. I don't see these messages on 5.10-rc7. I started
> seeing them on stable releases. It started right around 5.9.9 and
> not present on 5.9.7.
What kind of machine?
> I am bisecting to isolate. Same issue on all stables 5.4, 4.19 and
> so on. If it is BIOS problem I would expect to see it on 5.10-rc7
> and wouldn't have expected to start seeing it 5.9.9.
Can you provide some more details, e.g. dmesg please?
>> No. It's perfectly correct in the MSI code. See further down.
>>
>> if (IS_ERR_OR_NULL(this_cpu_read(vector_irq[cfg->vector])))
>> this_cpu_write(vector_irq[cfg->vector], VECTOR_RETRIGGERED);
>>
>
> I am asking about inconsistent comments and the actual message as the
> comment implies if vector is VECTOR_UNUSED state, this message won't
> be triggered in common_interrupt. Based on that my read is the comment
> might be wrong if the code is correct as you are saying.
The comment says:
>> * anyway. If the vector is unused, then it is marked so it won't
>> * trigger the 'No irq handler for vector' warning in
>> * common_interrupt().
If the vector is unused, then it is _marked_ so ....
It perhaps should explicitely say 'is marked as VECTOR_RETRIGGERED' to make
it clear.
Thanks,
tglx
next prev parent reply other threads:[~2020-12-14 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 20:41 common_interrupt: No irq handler for vector Shuah Khan
2020-12-12 19:33 ` Thomas Gleixner
2020-12-14 16:11 ` Shuah Khan
2020-12-14 20:41 ` Thomas Gleixner [this message]
2020-12-14 20:50 ` Thomas Gleixner
2020-12-14 20:57 ` Shuah Khan
2020-12-14 22:28 ` Thomas Gleixner
2020-12-14 22:41 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfe0dst1.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).