From: Kalle Valo <kvalo@codeaurora.org>
To: Joe Perches <joe@perches.com>
Cc: Rick Veens <rickveens92@gmail.com>,
gregkh@linuxfoundation.org, Ping-Ke Shih <pkshih@realtek.com>,
Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
Date: Mon, 01 Oct 2018 07:15:43 +0300 [thread overview]
Message-ID: <87in2ml2ts.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <7c4f645219bb69f31777367d5edc0830c32467db.camel@perches.com> (Joe Perches's message of "Sun, 30 Sep 2018 11:35:01 -0700")
Joe Perches <joe@perches.com> writes:
> On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
>> The following:
>> bool efuse_re_pg_sec1flag;
>> u8 efuse_re_pg_data[8];
>> are not referenced anywhere in the rtlwifi code.
>>
>> Signed-off-by: Rick Veens <rickveens92@gmail.com>
>> ---
>> drivers/staging/rtlwifi/wifi.h | 4 ----
>
> Presumably the equivalent uses in
> drivers/net/wireless/realtek/rtlwifi/wifi.h
> should be removed as well.
But if it's needed, just do it in separate patch as the patches go via
different trees.
--
Kalle Valo
next prev parent reply other threads:[~2018-10-01 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 18:29 [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h Rick Veens
2018-09-30 18:35 ` Joe Perches
2018-10-01 4:15 ` Kalle Valo [this message]
2018-10-01 9:01 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in2ml2ts.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rickveens92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).