* [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
@ 2018-09-30 18:29 Rick Veens
2018-09-30 18:35 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Rick Veens @ 2018-09-30 18:29 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, devel, linux-kernel
The following:
bool efuse_re_pg_sec1flag;
u8 efuse_re_pg_data[8];
are not referenced anywhere in the rtlwifi code.
Signed-off-by: Rick Veens <rickveens92@gmail.com>
---
drivers/staging/rtlwifi/wifi.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtlwifi/wifi.h b/drivers/staging/rtlwifi/wifi.h
index a45f0eb..9cb6c79 100644
--- a/drivers/staging/rtlwifi/wifi.h
+++ b/drivers/staging/rtlwifi/wifi.h
@@ -1840,10 +1840,6 @@ struct rtl_efuse {
u8 efuse_map[2][EFUSE_MAX_LOGICAL_SIZE];
u16 efuse_usedbytes;
u8 efuse_usedpercentage;
-#ifdef EFUSE_REPG_WORKAROUND
- bool efuse_re_pg_sec1flag;
- u8 efuse_re_pg_data[8];
-#endif
u8 autoload_failflag;
u8 autoload_status;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
2018-09-30 18:29 [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h Rick Veens
@ 2018-09-30 18:35 ` Joe Perches
2018-10-01 4:15 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2018-09-30 18:35 UTC (permalink / raw)
To: Rick Veens, gregkh, Ping-Ke Shih, Kalle Valo
Cc: Larry.Finger, devel, linux-kernel
On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
> The following:
> bool efuse_re_pg_sec1flag;
> u8 efuse_re_pg_data[8];
> are not referenced anywhere in the rtlwifi code.
>
> Signed-off-by: Rick Veens <rickveens92@gmail.com>
> ---
> drivers/staging/rtlwifi/wifi.h | 4 ----
Presumably the equivalent uses in
drivers/net/wireless/realtek/rtlwifi/wifi.h
should be removed as well.
> diff --git a/drivers/staging/rtlwifi/wifi.h b/drivers/staging/rtlwifi/wifi.h
[]
> @@ -1840,10 +1840,6 @@ struct rtl_efuse {
> u8 efuse_map[2][EFUSE_MAX_LOGICAL_SIZE];
> u16 efuse_usedbytes;
> u8 efuse_usedpercentage;
> -#ifdef EFUSE_REPG_WORKAROUND
> - bool efuse_re_pg_sec1flag;
> - u8 efuse_re_pg_data[8];
> -#endif
>
> u8 autoload_failflag;
> u8 autoload_status;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
2018-09-30 18:35 ` Joe Perches
@ 2018-10-01 4:15 ` Kalle Valo
2018-10-01 9:01 ` Pkshih
0 siblings, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2018-10-01 4:15 UTC (permalink / raw)
To: Joe Perches
Cc: Rick Veens, gregkh, Ping-Ke Shih, Larry.Finger, devel, linux-kernel
Joe Perches <joe@perches.com> writes:
> On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
>> The following:
>> bool efuse_re_pg_sec1flag;
>> u8 efuse_re_pg_data[8];
>> are not referenced anywhere in the rtlwifi code.
>>
>> Signed-off-by: Rick Veens <rickveens92@gmail.com>
>> ---
>> drivers/staging/rtlwifi/wifi.h | 4 ----
>
> Presumably the equivalent uses in
> drivers/net/wireless/realtek/rtlwifi/wifi.h
> should be removed as well.
But if it's needed, just do it in separate patch as the patches go via
different trees.
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
2018-10-01 4:15 ` Kalle Valo
@ 2018-10-01 9:01 ` Pkshih
0 siblings, 0 replies; 4+ messages in thread
From: Pkshih @ 2018-10-01 9:01 UTC (permalink / raw)
To: joe, kvalo; +Cc: linux-kernel, devel, gregkh, rickveens92, Larry.Finger
On Mon, 2018-10-01 at 07:15 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
>
> > On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
> >> The following:
> >> bool efuse_re_pg_sec1flag;
> >> u8 efuse_re_pg_data[8];
> >> are not referenced anywhere in the rtlwifi code.
> >>
> >> Signed-off-by: Rick Veens <rickveens92@gmail.com>
> >> ---
> >> drivers/staging/rtlwifi/wifi.h | 4 ----
> >
> > Presumably the equivalent uses in
> > drivers/net/wireless/realtek/rtlwifi/wifi.h
> > should be removed as well.
>
> But if it's needed, just do it in separate patch as the patches go via
> different trees.
>
I can send this patch.
--
PK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-01 9:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-30 18:29 [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h Rick Veens
2018-09-30 18:35 ` Joe Perches
2018-10-01 4:15 ` Kalle Valo
2018-10-01 9:01 ` Pkshih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).