[PATCH] perf: Remove unneeded include

[PATCH] perf: Remove unneeded include

[Rodrigo Campos]

There is no point in sort.h including itself.

The include was added when the file was created, in commit "perf tools: Create
util/sort.and use it" (dd68ada2d) and added a include to "sort.h" in lot of
files (all the files that started using the file). It was probably added by
mistake on sort.h too.

Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
---
 tools/perf/util/sort.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index f4cc147..43e5ff4 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -22,7 +22,6 @@
 #include "parse-events.h"
 
 #include "thread.h"
-#include "sort.h"
 
 extern regex_t parent_regex;
 extern const char *sort_order;
-- 
1.8.4.rc3

Re: [PATCH] perf: Remove unneeded include

[Namhyung Kim]

Hi Rodrigo,

On Wed,  6 Nov 2013 22:20:54 +0000, Rodrigo Campos wrote:
> There is no point in sort.h including itself.
>
> The include was added when the file was created, in commit "perf tools: Create
> util/sort.and use it" (dd68ada2d) and added a include to "sort.h" in lot of
> files (all the files that started using the file). It was probably added by
> mistake on sort.h too.

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

[tip:perf/core] perf tools: Remove unneeded include

[tip-bot for Rodrigo Campos]

Commit-ID:  8ce000e83848578a621d64eccdc88bd34c2fc70c
Gitweb:     http://git.kernel.org/tip/8ce000e83848578a621d64eccdc88bd34c2fc70c
Author:     Rodrigo Campos <rodrigo@sdfg.com.ar>
AuthorDate: Wed, 6 Nov 2013 22:20:54 +0000
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 7 Nov 2013 11:51:19 -0300

perf tools: Remove unneeded include

There is no point in sort.h including itself.

The include was added when the file was created, in commit "perf tools:
Create util/sort.and use it" (dd68ada2d) and added a include to "sort.h"
in lot of files (all the files that started using the file). It was
probably added by mistake on sort.h too.

Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1383776454-10595-1-git-send-email-rodrigo@sdfg.com.ar
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/sort.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index f4cc147..43e5ff4 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -22,7 +22,6 @@
 #include "parse-events.h"
 
 #include "thread.h"
-#include "sort.h"
 
 extern regex_t parent_regex;
 extern const char *sort_order;