* [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic @ 2022-03-24 22:11 Joel Savitz 2022-04-21 19:24 ` Joel Savitz 0 siblings, 1 reply; 5+ messages in thread From: Joel Savitz @ 2022-03-24 22:11 UTC (permalink / raw) To: linux-kernel Cc: Joel Savitz, Jonathan Corbet, Andrew Morton, Huang Ying, Eric Biggers, Dominik Brodowski, Mauro Carvalho Chehab, Rasmus Villemoes, Jason A. Donenfeld, Daniel Borkmann, Rob Herring, Wang Qing, linux-doc commit dfe564045c65 ("rcu: Panic after fixed number of stalls") introduced a new systctl but no accompanying documentation. Add a simple entry to the documentation. Signed-off-by: Joel Savitz <jsavitz@redhat.com> --- Documentation/admin-guide/sysctl/kernel.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst index 803c60bf21d3..4e48139b9a34 100644 --- a/Documentation/admin-guide/sysctl/kernel.rst +++ b/Documentation/admin-guide/sysctl/kernel.rst @@ -781,6 +781,13 @@ is useful to define the root cause of RCU stalls using a vmcore. 1 panic() after printing RCU stall messages. = ============================================================ +max_rcu_stall_to_panic +====================== + +When ``panic_on_rcu_stall`` is set to 1, this value determines the +number of times that RCU can stall before panic() is called. + +When ``panic_on_rcu_stall`` is set to 0, this value is has no effect. perf_cpu_time_max_percent ========================= -- 2.27.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic 2022-03-24 22:11 [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic Joel Savitz @ 2022-04-21 19:24 ` Joel Savitz 2022-04-28 18:39 ` Jonathan Corbet 0 siblings, 1 reply; 5+ messages in thread From: Joel Savitz @ 2022-04-21 19:24 UTC (permalink / raw) To: linux-kernel Cc: Jonathan Corbet, Andrew Morton, Huang Ying, Eric Biggers, Dominik Brodowski, Mauro Carvalho Chehab, Rasmus Villemoes, Jason A. Donenfeld, Daniel Borkmann, Rob Herring, Wang Qing, linux-doc Friendly ping. Joel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic 2022-04-21 19:24 ` Joel Savitz @ 2022-04-28 18:39 ` Jonathan Corbet 2022-04-28 18:49 ` Paul E. McKenney 0 siblings, 1 reply; 5+ messages in thread From: Jonathan Corbet @ 2022-04-28 18:39 UTC (permalink / raw) To: Joel Savitz, linux-kernel Cc: Andrew Morton, Huang Ying, Eric Biggers, Dominik Brodowski, Mauro Carvalho Chehab, Rasmus Villemoes, Jason A. Donenfeld, Daniel Borkmann, Rob Herring, Wang Qing, linux-doc, chao, Paul E. McKenney Joel Savitz <jsavitz@redhat.com> writes: > Friendly ping. This was waiting for an ack from an RCU person. Looking now, though, I see that you didn't copy any RCU people. Adding Paul and the author of the patch you reference (and appending patch below). Thanks, jon Joel Savitz <jsavitz@redhat.com> (March 24) (kernel lwn) Subject: [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic To: linux-kernel@vger.kernel.org Cc: Joel Savitz <jsavitz@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Andrew Morton <akpm@linux-foundation.org>, Huang Ying <ying.huang@intel.com>, Eric Biggers <ebiggers@google.com>, Dominik Brodowski <linux@dominikbrodowski.net>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, "Jason A. Donenfeld" <Jason@zx2c4.com>, Daniel Borkmann <daniel@iogearbox.net>, Rob Herring <robh@kernel.org>, Wang Qing <wangqing@vivo.com>, linux-doc@vger.kernel.org Date: Thu, 24 Mar 2022 18:11:56 -0400 commit dfe564045c65 ("rcu: Panic after fixed number of stalls") introduced a new systctl but no accompanying documentation. Add a simple entry to the documentation. Signed-off-by: Joel Savitz <jsavitz@redhat.com> --- Documentation/admin-guide/sysctl/kernel.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst index 803c60bf21d3..4e48139b9a34 100644 --- a/Documentation/admin-guide/sysctl/kernel.rst +++ b/Documentation/admin-guide/sysctl/kernel.rst @@ -781,6 +781,13 @@ is useful to define the root cause of RCU stalls using a vmcore. 1 panic() after printing RCU stall messages. = ============================================================ +max_rcu_stall_to_panic +====================== + +When ``panic_on_rcu_stall`` is set to 1, this value determines the +number of times that RCU can stall before panic() is called. + +When ``panic_on_rcu_stall`` is set to 0, this value is has no effect. perf_cpu_time_max_percent ========================= ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic 2022-04-28 18:39 ` Jonathan Corbet @ 2022-04-28 18:49 ` Paul E. McKenney 2022-05-01 23:15 ` Jonathan Corbet 0 siblings, 1 reply; 5+ messages in thread From: Paul E. McKenney @ 2022-04-28 18:49 UTC (permalink / raw) To: Jonathan Corbet Cc: Joel Savitz, linux-kernel, Andrew Morton, Huang Ying, Eric Biggers, Dominik Brodowski, Mauro Carvalho Chehab, Rasmus Villemoes, Jason A. Donenfeld, Daniel Borkmann, Rob Herring, Wang Qing, linux-doc, chao On Thu, Apr 28, 2022 at 12:39:54PM -0600, Jonathan Corbet wrote: > Joel Savitz <jsavitz@redhat.com> writes: > > > Friendly ping. > > This was waiting for an ack from an RCU person. Looking now, though, I > see that you didn't copy any RCU people. Adding Paul and the author of > the patch you reference (and appending patch below). Thank you for calling this to my attention. ;-) > Thanks, > > jon > > Joel Savitz <jsavitz@redhat.com> (March 24) (kernel lwn) > Subject: [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic > To: linux-kernel@vger.kernel.org > Cc: Joel Savitz <jsavitz@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Andrew Morton <akpm@linux-foundation.org>, Huang Ying <ying.huang@intel.com>, Eric Biggers <ebiggers@google.com>, Dominik Brodowski <linux@dominikbrodowski.net>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, "Jason A. Donenfeld" <Jason@zx2c4.com>, Daniel Borkmann <daniel@iogearbox.net>, Rob Herring <robh@kernel.org>, Wang Qing <wangqing@vivo.com>, linux-doc@vger.kernel.org > Date: Thu, 24 Mar 2022 18:11:56 -0400 > > commit dfe564045c65 ("rcu: Panic after fixed number of stalls") > introduced a new systctl but no accompanying documentation. > > Add a simple entry to the documentation. > > Signed-off-by: Joel Savitz <jsavitz@redhat.com> Acked-by: Paul E. McKenney <paulmck@kernel.org> > --- > Documentation/admin-guide/sysctl/kernel.rst | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst > index 803c60bf21d3..4e48139b9a34 100644 > --- a/Documentation/admin-guide/sysctl/kernel.rst > +++ b/Documentation/admin-guide/sysctl/kernel.rst > @@ -781,6 +781,13 @@ is useful to define the root cause of RCU stalls using a vmcore. > 1 panic() after printing RCU stall messages. > = ============================================================ > > +max_rcu_stall_to_panic > +====================== > + > +When ``panic_on_rcu_stall`` is set to 1, this value determines the > +number of times that RCU can stall before panic() is called. > + > +When ``panic_on_rcu_stall`` is set to 0, this value is has no effect. > > perf_cpu_time_max_percent > ========================= ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic 2022-04-28 18:49 ` Paul E. McKenney @ 2022-05-01 23:15 ` Jonathan Corbet 0 siblings, 0 replies; 5+ messages in thread From: Jonathan Corbet @ 2022-05-01 23:15 UTC (permalink / raw) To: paulmck Cc: Joel Savitz, linux-kernel, Andrew Morton, Huang Ying, Eric Biggers, Dominik Brodowski, Mauro Carvalho Chehab, Rasmus Villemoes, Jason A. Donenfeld, Daniel Borkmann, Rob Herring, Wang Qing, linux-doc, chao "Paul E. McKenney" <paulmck@kernel.org> writes: >> commit dfe564045c65 ("rcu: Panic after fixed number of stalls") >> introduced a new systctl but no accompanying documentation. >> >> Add a simple entry to the documentation. >> >> Signed-off-by: Joel Savitz <jsavitz@redhat.com> > > Acked-by: Paul E. McKenney <paulmck@kernel.org> OK, applied, thanks. jon ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-01 23:15 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-24 22:11 [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic Joel Savitz 2022-04-21 19:24 ` Joel Savitz 2022-04-28 18:39 ` Jonathan Corbet 2022-04-28 18:49 ` Paul E. McKenney 2022-05-01 23:15 ` Jonathan Corbet
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).