Reusing DTS from arm64 to arm

Reusing DTS from arm64 to arm

[Vinod Koul]

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

Hello Olof, Rob,

We have Qualcomm arm platform which uses PMIC PM8150B. This PMIC was
also used in SM8150 board and is already upstream [1] but in arm64.

So, what is the guidance to share DTS files between 32 and 64 variants?
Does a solution already exist which I may not be aware of..?

I can think of following options for this, in case we dont have a
solution:

1. Hack up arm include paths to also include arm64 path so that we can
share DTS

2. Use relative path of arm64 directory and include that (seems not
great to look at)

3. Copy the file (simplest but least preferred)

Or is there a better idea to solve this...?

[1]: arch/arm64/boot/dts/qcom/pm8150b.dtsi

Thanks
-- 
~Vinod

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Reusing DTS from arm64 to arm

[Chen-Yu Tsai]

Hi,

On Tue, Nov 24, 2020 at 1:28 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> Hello Olof, Rob,
>
> We have Qualcomm arm platform which uses PMIC PM8150B. This PMIC was
> also used in SM8150 board and is already upstream [1] but in arm64.
>
> So, what is the guidance to share DTS files between 32 and 64 variants?
> Does a solution already exist which I may not be aware of..?
>
> I can think of following options for this, in case we dont have a
> solution:
>
> 1. Hack up arm include paths to also include arm64 path so that we can
> share DTS

These are already provided. See scripts/dtc/include-prefixes/ .

So just put

#include <arm64/qcom/pm8150b.dtsi>

in your DTS and it should work?

For Allwinner we have the reverse, i.e. including arm dts files from arm64.


Regards
ChenYu

> 2. Use relative path of arm64 directory and include that (seems not
> great to look at)
>
> 3. Copy the file (simplest but least preferred)
>
> Or is there a better idea to solve this...?
>
> [1]: arch/arm64/boot/dts/qcom/pm8150b.dtsi
>
> Thanks
> --
> ~Vinod
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: Reusing DTS from arm64 to arm

[Baruch Siach]

Hi Vinod,

On Tue, Nov 24 2020, Vinod Koul wrote:
> We have Qualcomm arm platform which uses PMIC PM8150B. This PMIC was
> also used in SM8150 board and is already upstream [1] but in arm64.
>
> So, what is the guidance to share DTS files between 32 and 64 variants?
> Does a solution already exist which I may not be aware of..?

You might want to take a look at Raspberry Pi. For example:

arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts:
// SPDX-License-Identifier: GPL-2.0
#include "arm/bcm2837-rpi-3-b.dts"

baruch

> I can think of following options for this, in case we dont have a
> solution:
>
> 1. Hack up arm include paths to also include arm64 path so that we can
> share DTS
>
> 2. Use relative path of arm64 directory and include that (seems not
> great to look at)
>
> 3. Copy the file (simplest but least preferred)
>
> Or is there a better idea to solve this...?
>
> [1]: arch/arm64/boot/dts/qcom/pm8150b.dtsi
>
> Thanks


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Re: Reusing DTS from arm64 to arm

[Vinod Koul]

Hello Chen-Yu,

On 24-11-20, 13:36, Chen-Yu Tsai wrote:
> Hi,
> 
> On Tue, Nov 24, 2020 at 1:28 PM Vinod Koul <vkoul@kernel.org> wrote:
> >
> > Hello Olof, Rob,
> >
> > We have Qualcomm arm platform which uses PMIC PM8150B. This PMIC was
> > also used in SM8150 board and is already upstream [1] but in arm64.
> >
> > So, what is the guidance to share DTS files between 32 and 64 variants?
> > Does a solution already exist which I may not be aware of..?
> >
> > I can think of following options for this, in case we dont have a
> > solution:
> >
> > 1. Hack up arm include paths to also include arm64 path so that we can
> > share DTS
> 
> These are already provided. See scripts/dtc/include-prefixes/ .
> 
> So just put
> 
> #include <arm64/qcom/pm8150b.dtsi>
> 
> in your DTS and it should work?

It does work, thank you for pointing me to this

-- 
~Vinod