linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation"
@ 2018-09-06 21:36 Brian Norris
  2018-09-11 14:47 ` Kalle Valo
  2018-10-11 14:14 ` Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Brian Norris @ 2018-09-06 21:36 UTC (permalink / raw)
  To: stable; +Cc: linux-kernel, linux-wireless, Zhi Chen, Kalle Valo, ath10k

Hi Greg / stable maintainer(s),

IIUC, this commit is a good candidate for -stable. I just hit the bug on
4.14, because of new vendor firmware that noticed the mismatched length
(an internal "assert"), but it seems like this is equally problematic
from the kernel side for as long as this code existed [1]:

commit c8291988806407e02a01b4b15b4504eafbcc04e0
Author: Zhi Chen <zhichen@codeaurora.org>
Date:   Mon Jun 18 17:00:39 2018 +0300

    ath10k: fix scan crash due to incorrect length calculation

Thanks,
Brian

[1] I guess that would be:

Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")

which was in v4.0.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation"
  2018-09-06 21:36 [for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation" Brian Norris
@ 2018-09-11 14:47 ` Kalle Valo
  2018-10-11 14:14 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-09-11 14:47 UTC (permalink / raw)
  To: Brian Norris; +Cc: stable, linux-kernel, linux-wireless, Zhi Chen, ath10k

Brian Norris <briannorris@chromium.org> writes:

> Hi Greg / stable maintainer(s),
>
> IIUC, this commit is a good candidate for -stable. I just hit the bug on
> 4.14, because of new vendor firmware that noticed the mismatched length
> (an internal "assert"), but it seems like this is equally problematic
> from the kernel side for as long as this code existed [1]:
>
> commit c8291988806407e02a01b4b15b4504eafbcc04e0
> Author: Zhi Chen <zhichen@codeaurora.org>
> Date:   Mon Jun 18 17:00:39 2018 +0300
>
>     ath10k: fix scan crash due to incorrect length calculation
>
> Thanks,
> Brian
>
> [1] I guess that would be:
>
> Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
>
> which was in v4.0.

FWIW:

Acked-by: Kalle Valo <kvalo@codeaurora.org>

Thanks Brian!

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation"
  2018-09-06 21:36 [for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation" Brian Norris
  2018-09-11 14:47 ` Kalle Valo
@ 2018-10-11 14:14 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-10-11 14:14 UTC (permalink / raw)
  To: Brian Norris
  Cc: stable, linux-kernel, linux-wireless, Zhi Chen, Kalle Valo, ath10k

On Thu, Sep 06, 2018 at 02:36:22PM -0700, Brian Norris wrote:
> Hi Greg / stable maintainer(s),
> 
> IIUC, this commit is a good candidate for -stable. I just hit the bug on
> 4.14, because of new vendor firmware that noticed the mismatched length
> (an internal "assert"), but it seems like this is equally problematic
> from the kernel side for as long as this code existed [1]:
> 
> commit c8291988806407e02a01b4b15b4504eafbcc04e0
> Author: Zhi Chen <zhichen@codeaurora.org>
> Date:   Mon Jun 18 17:00:39 2018 +0300
> 
>     ath10k: fix scan crash due to incorrect length calculation
> 
> Thanks,
> Brian
> 
> [1] I guess that would be:
> 
> Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
> 
> which was in v4.0.

Thanks, now queued up.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-11 14:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-06 21:36 [for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation" Brian Norris
2018-09-11 14:47 ` Kalle Valo
2018-10-11 14:14 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).