* [PATCH] Documentation: checkpatch: Add SPLIT_STRING message
@ 2021-09-04 7:36 Utkarsh Verma
2021-09-14 21:07 ` Jonathan Corbet
0 siblings, 1 reply; 2+ messages in thread
From: Utkarsh Verma @ 2021-09-04 7:36 UTC (permalink / raw)
To: Dwaipayan Ray
Cc: Lukas Bulwahn, Joe Perches, Jonathan Corbet, linux-doc,
linux-kernel, Utkarsh Verma
Add a new message type SPLIT_STRING under the 'Indentation and Line
Breaks' subsection. Checkpatch documentation for the splitting of
quoted strings that appear in userspace, across multiple lines.
Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Utkarsh Verma <utkarshverma294@gmail.com>
---
Documentation/dev-tools/checkpatch.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
index f0956e9ea2d8..b7a1288e96a9 100644
--- a/Documentation/dev-tools/checkpatch.rst
+++ b/Documentation/dev-tools/checkpatch.rst
@@ -710,6 +710,12 @@ Indentation and Line Breaks
See: https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings
+ **SPLIT_STRING**
+ Quoted strings that appear as messages in userspace and can be
+ grepped, should not be split across multiple lines.
+
+ See: https://lore.kernel.org/lkml/20120203052727.GA15035@leaf/
+
**TRAILING_STATEMENTS**
Trailing statements (for example after any conditional) should be
on the next line.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation: checkpatch: Add SPLIT_STRING message
2021-09-04 7:36 [PATCH] Documentation: checkpatch: Add SPLIT_STRING message Utkarsh Verma
@ 2021-09-14 21:07 ` Jonathan Corbet
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2021-09-14 21:07 UTC (permalink / raw)
To: Utkarsh Verma, Dwaipayan Ray
Cc: Lukas Bulwahn, Joe Perches, linux-doc, linux-kernel, Utkarsh Verma
Utkarsh Verma <utkarshverma294@gmail.com> writes:
> Add a new message type SPLIT_STRING under the 'Indentation and Line
> Breaks' subsection. Checkpatch documentation for the splitting of
> quoted strings that appear in userspace, across multiple lines.
>
> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Signed-off-by: Utkarsh Verma <utkarshverma294@gmail.com>
> ---
> Documentation/dev-tools/checkpatch.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-14 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-04 7:36 [PATCH] Documentation: checkpatch: Add SPLIT_STRING message Utkarsh Verma
2021-09-14 21:07 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).