* [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h
@ 2018-07-27 16:07 Nishad Kamdar
2018-07-30 22:10 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Nishad Kamdar @ 2018-07-27 16:07 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Christian Lütke-Stetzkamp, NeilBrown, John Crispin, devel,
linux-kernel
Replace explicit shifting with BIT macro in board.h.
Issue found by checkpatch.
Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
drivers/staging/mt7621-mmc/board.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/board.h b/drivers/staging/mt7621-mmc/board.h
index a7d82f321b00..983791ee308d 100644
--- a/drivers/staging/mt7621-mmc/board.h
+++ b/drivers/staging/mt7621-mmc/board.h
@@ -36,10 +36,10 @@
#ifndef __ARCH_ARM_MACH_BOARD_H
#define __ARCH_ARM_MACH_BOARD_H
-#define MSDC_CD_PIN_EN (1 << 0) /* card detection pin is wired */
-#define MSDC_WP_PIN_EN (1 << 1) /* write protection pin is wired */
-#define MSDC_RST_PIN_EN (1 << 2) /* emmc reset pin is wired */
-#define MSDC_REMOVABLE (1 << 5) /* removable slot */
+#define MSDC_CD_PIN_EN BIT(0) /* card detection pin is wired */
+#define MSDC_WP_PIN_EN BIT(1) /* write protection pin is wired */
+#define MSDC_RST_PIN_EN BIT(2) /* emmc reset pin is wired */
+#define MSDC_REMOVABLE BIT(5) /* removable slot */
#define MSDC_SMPL_RISING (0)
#define MSDC_SMPL_FALLING (1)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h
2018-07-27 16:07 [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h Nishad Kamdar
@ 2018-07-30 22:10 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2018-07-30 22:10 UTC (permalink / raw)
To: Nishad Kamdar, Greg Kroah-Hartman
Cc: Christian Lütke-Stetzkamp, John Crispin, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]
On Fri, Jul 27 2018, Nishad Kamdar wrote:
> Replace explicit shifting with BIT macro in board.h.
> Issue found by checkpatch.
>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
Thanks,
NeilBrown
> ---
> drivers/staging/mt7621-mmc/board.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/board.h b/drivers/staging/mt7621-mmc/board.h
> index a7d82f321b00..983791ee308d 100644
> --- a/drivers/staging/mt7621-mmc/board.h
> +++ b/drivers/staging/mt7621-mmc/board.h
> @@ -36,10 +36,10 @@
> #ifndef __ARCH_ARM_MACH_BOARD_H
> #define __ARCH_ARM_MACH_BOARD_H
>
> -#define MSDC_CD_PIN_EN (1 << 0) /* card detection pin is wired */
> -#define MSDC_WP_PIN_EN (1 << 1) /* write protection pin is wired */
> -#define MSDC_RST_PIN_EN (1 << 2) /* emmc reset pin is wired */
> -#define MSDC_REMOVABLE (1 << 5) /* removable slot */
> +#define MSDC_CD_PIN_EN BIT(0) /* card detection pin is wired */
> +#define MSDC_WP_PIN_EN BIT(1) /* write protection pin is wired */
> +#define MSDC_RST_PIN_EN BIT(2) /* emmc reset pin is wired */
> +#define MSDC_REMOVABLE BIT(5) /* removable slot */
>
> #define MSDC_SMPL_RISING (0)
> #define MSDC_SMPL_FALLING (1)
> --
> 2.17.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-30 22:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 16:07 [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h Nishad Kamdar
2018-07-30 22:10 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).