From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 1/6] net: dsa: remove trans argument from mdb ops
Date: Thu, 09 Nov 2017 10:06:49 -0500 [thread overview]
Message-ID: <87mv3vqynq.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <01a09219-c348-5aa5-c052-c8ea505c769d@egil-hjelmeland.no>
Hi Egil,
Egil Hjelmeland <privat@egil-hjelmeland.no> writes:
> On 08. nov. 2017 18:19, Vivien Didelot wrote:
>> The DSA switch MDB ops pass the switchdev_trans structure down to the
>> drivers, but no one is using them and they aren't supposed to anyway.
>>
>> Remove the trans argument from MDB prepare and add operations.
>>
>> - int (*port_mdb_prepare)(struct dsa_switch *ds, int port,
>> - const struct switchdev_obj_port_mdb *mdb,
>> - struct switchdev_trans *trans);
>> - void (*port_mdb_add)(struct dsa_switch *ds, int port,
>> - const struct switchdev_obj_port_mdb *mdb,
>> - struct switchdev_trans *trans);
>> + int (*port_mdb_prepare)(struct dsa_switch *ds, int port,
>> + const struct switchdev_obj_port_mdb *mdb);
>> + void (*port_mdb_add)(struct dsa_switch *ds, int port,
>> + const struct switchdev_obj_port_mdb *mdb);
>> int (*port_mdb_del)(struct dsa_switch *ds, int port,
>> const struct switchdev_obj_port_mdb *mdb);
>
> Hi Vivien
> Nice to get rid of "trans". I recall I was confused by this parameter.
> "Am I supposed to do something with this parameter?".
>
> But when at it. What about getting rid of switchdev_obj_port_mdb, making
> similar signatures as the new .port_fdb_xxx functions? Would that make
> sense?
There is definitely something to do to factorize FDB and MDB operations,
since an Ethernet switch driver will only manipulate an address database
in the end. I have something in mind but this is out-of-scope ATM.
Thanks,
Vivien
next prev parent reply other threads:[~2017-11-09 15:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 17:19 [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 1/6] net: dsa: remove trans argument from mdb ops Vivien Didelot
2017-11-09 9:04 ` Egil Hjelmeland
2017-11-09 15:06 ` Vivien Didelot [this message]
2017-11-08 17:19 ` [PATCH net-next 2/6] net: dsa: return after mdb prepare phase Vivien Didelot
2017-11-09 8:48 ` Egil Hjelmeland
2017-11-08 17:19 ` [PATCH net-next 3/6] net: dsa: add switch mdb bitmap functions Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops Vivien Didelot
2017-11-08 17:49 ` Joe Perches
2017-11-08 19:05 ` Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 5/6] net: dsa: return after vlan prepare phase Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 6/6] net: dsa: add switch vlan bitmap functions Vivien Didelot
2017-11-11 6:50 ` [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv3vqynq.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me \
--to=vivien.didelot@savoirfairelinux.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).