From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Joe Perches <joe@perches.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops
Date: Wed, 08 Nov 2017 14:05:02 -0500 [thread overview]
Message-ID: <87zi7w617l.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1510163351.15768.29.camel@perches.com>
Hi Joe,
Joe Perches <joe@perches.com> writes:
> On Wed, 2017-11-08 at 12:19 -0500, Vivien Didelot wrote:
>> The DSA switch VLAN ops pass the switchdev_trans structure down to the
>> drivers, but no one is using them and they aren't supposed to anyway.
> []
>> diff --git a/include/net/dsa.h b/include/net/dsa.h
> []
>> @@ -410,12 +410,10 @@ struct dsa_switch_ops {
>> */
>> int (*port_vlan_filtering)(struct dsa_switch *ds, int port,
>> bool vlan_filtering);
>> - int (*port_vlan_prepare)(struct dsa_switch *ds, int port,
>> - const struct switchdev_obj_port_vlan *vlan,
>> - struct switchdev_trans *trans);
>> - void (*port_vlan_add)(struct dsa_switch *ds, int port,
>> - const struct switchdev_obj_port_vlan *vlan,
>> - struct switchdev_trans *trans);
>> + int (*port_vlan_prepare)(struct dsa_switch *ds, int port,
>> + const struct switchdev_obj_port_vlan *vlan);
>> + void (*port_vlan_add)(struct dsa_switch *ds, int port,
>> + const struct switchdev_obj_port_vlan *vlan);
>> int (*port_vlan_del)(struct dsa_switch *ds, int port,
>> const struct switchdev_obj_port_vlan *vlan);
>
> I think this bit is slightly worse.
> Mixing alignment styles seems odd.
>
> I think it's better to either align all the (*func) uses
> on a tabstop or
> none of them.
I couldn't use a tab here as it is done in the other functions, because
of the 80-char limit. I will send a patch soon to remove all of this
alignment style in this header because it doesn't bring any value.
Thanks,
Vivien
next prev parent reply other threads:[~2017-11-08 19:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 17:19 [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 1/6] net: dsa: remove trans argument from mdb ops Vivien Didelot
2017-11-09 9:04 ` Egil Hjelmeland
2017-11-09 15:06 ` Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 2/6] net: dsa: return after mdb prepare phase Vivien Didelot
2017-11-09 8:48 ` Egil Hjelmeland
2017-11-08 17:19 ` [PATCH net-next 3/6] net: dsa: add switch mdb bitmap functions Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops Vivien Didelot
2017-11-08 17:49 ` Joe Perches
2017-11-08 19:05 ` Vivien Didelot [this message]
2017-11-08 17:19 ` [PATCH net-next 5/6] net: dsa: return after vlan prepare phase Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 6/6] net: dsa: add switch vlan bitmap functions Vivien Didelot
2017-11-11 6:50 ` [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi7w617l.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me \
--to=vivien.didelot@savoirfairelinux.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joe@perches.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).