* [PATCH] wireless/ath/ath9k: remove redundant status variable
@ 2022-01-12 8:07 cgel.zte
2022-01-12 8:16 ` Kalle Valo
2022-01-17 12:43 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2022-01-12 8:07 UTC (permalink / raw)
To: kvalo
Cc: ath9k-devel, davem, kuba, linux-wireless, netdev, linux-kernel,
Minghao Chi, Zeal Robot, CGEL ZTE
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value directly instead of taking this in another redundant
variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
drivers/net/wireless/ath/ath9k/eeprom.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c
index e6b3cd49ea18..efb7889142d4 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/eeprom.c
@@ -670,8 +670,6 @@ void ath9k_hw_get_gain_boundaries_pdadcs(struct ath_hw *ah,
int ath9k_hw_eeprom_init(struct ath_hw *ah)
{
- int status;
-
if (AR_SREV_9300_20_OR_LATER(ah))
ah->eep_ops = &eep_ar9300_ops;
else if (AR_SREV_9287(ah)) {
@@ -685,7 +683,5 @@ int ath9k_hw_eeprom_init(struct ath_hw *ah)
if (!ah->eep_ops->fill_eeprom(ah))
return -EIO;
- status = ah->eep_ops->check_eeprom(ah);
-
- return status;
+ return ah->eep_ops->check_eeprom(ah);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wireless/ath/ath9k: remove redundant status variable
2022-01-12 8:07 [PATCH] wireless/ath/ath9k: remove redundant status variable cgel.zte
@ 2022-01-12 8:16 ` Kalle Valo
2022-01-17 12:43 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-01-12 8:16 UTC (permalink / raw)
To: cgel.zte
Cc: ath9k-devel, davem, kuba, linux-wireless, netdev, linux-kernel,
Minghao Chi, Zeal Robot
cgel.zte@gmail.com writes:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this in another redundant
> variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
> drivers/net/wireless/ath/ath9k/eeprom.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
The subject prefix should be "ath9k:", I can fix that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wireless/ath/ath9k: remove redundant status variable
2022-01-12 8:07 [PATCH] wireless/ath/ath9k: remove redundant status variable cgel.zte
2022-01-12 8:16 ` Kalle Valo
@ 2022-01-17 12:43 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-01-17 12:43 UTC (permalink / raw)
To: cgel.zte
Cc: ath9k-devel, davem, kuba, linux-wireless, netdev, linux-kernel,
Minghao Chi, Zeal Robot, CGEL ZTE
cgel.zte@gmail.com wrote:
> Return value directly instead of taking this in another redundant
> variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
76d7b996aab8 ath9k: remove redundant status variable
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220112080751.667316-1-chi.minghao@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-17 12:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 8:07 [PATCH] wireless/ath/ath9k: remove redundant status variable cgel.zte
2022-01-12 8:16 ` Kalle Valo
2022-01-17 12:43 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).