From: Thomas Gleixner <tglx@linutronix.de>
To: Bixuan Cui <cuibixuan@huawei.com>, linux-kernel@vger.kernel.org
Cc: maz@kernel.org, john.wanghui@huawei.com
Subject: Re: [PATCH -next] irqdomain: fix overflow error
Date: Tue, 14 Sep 2021 13:56:34 +0200 [thread overview]
Message-ID: <87o88vcqvh.ffs@tglx> (raw)
In-Reply-To: <20210908014623.61357-1-cuibixuan@huawei.com>
On Wed, Sep 08 2021 at 09:46, Bixuan Cui wrote:
> In function ‘kmalloc_node’,
> inlined from ‘kzalloc_node.constprop’ at ./include/linux/slab.h:743:9,
> inlined from ‘__irq_domain_add’ at kernel/irq/irqdomain.c:153:9:
> ./include/linux/slab.h:618:9: error: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807 [-Werror=alloc-size-larger-than=]
> return __kmalloc_node(size, flags, node);
>
> The 'size' can be negative here, which will then get turned into a giant
> size argument for kzalloc_node(). Changing the size to 'unsigned int'
> instead seems more appropriate.
What's more appropriate about that?
Thanks,
tglx
next prev parent reply other threads:[~2021-09-14 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 1:46 [PATCH -next] irqdomain: fix overflow error Bixuan Cui
2021-09-14 11:56 ` Thomas Gleixner [this message]
2021-09-15 2:03 ` Bixuan Cui
2021-09-15 7:49 ` Thomas Gleixner
2021-09-15 9:38 ` Bixuan Cui
2021-09-16 2:37 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o88vcqvh.ffs@tglx \
--to=tglx@linutronix.de \
--cc=cuibixuan@huawei.com \
--cc=john.wanghui@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).