linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Bixuan Cui <cuibixuan@huawei.com>, linux-kernel@vger.kernel.org
Cc: maz@kernel.org, john.wanghui@huawei.com
Subject: Re: [PATCH -next] irqdomain: fix overflow error
Date: Wed, 15 Sep 2021 09:49:15 +0200	[thread overview]
Message-ID: <87pmtab7no.ffs@tglx> (raw)
In-Reply-To: <4f614b66-ad85-7fa3-6e6e-2a672e8148e3@huawei.com>

On Wed, Sep 15 2021 at 10:03, Bixuan Cui wrote:
> On 2021/9/14 19:56, Thomas Gleixner wrote:
>
> And kernel/irq/irqdomain.c
> struct irq_domain *irq_domain_create_simple(struct fwnode_handle *fwnode,
>                                             unsigned int size,
>                                             unsigned int first_irq,
>                                             const struct irq_domain_ops *ops,
>                                             void *host_data)
> {
>         struct irq_domain *domain;
>
>         domain = __irq_domain_add(fwnode, size, size, 0, ops, host_data);
>
> All 'size' passed to __irq_domain_add() are unsigned int.
>
> So I think it's more appropriate to replace it with unsigned int.

Appropriate is not really a technical reason. Making the code consistent
is.

But that has nothing to do with the completely bogus compiler warning in
the changelog you provided.

Thanks,

        tglx

  reply	other threads:[~2021-09-15  7:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08  1:46 [PATCH -next] irqdomain: fix overflow error Bixuan Cui
2021-09-14 11:56 ` Thomas Gleixner
2021-09-15  2:03   ` Bixuan Cui
2021-09-15  7:49     ` Thomas Gleixner [this message]
2021-09-15  9:38       ` Bixuan Cui
2021-09-16  2:37       ` Bixuan Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmtab7no.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=cuibixuan@huawei.com \
    --cc=john.wanghui@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).