From: Thomas Gleixner <tglx@linutronix.de>
To: Andrei Vagin <avagin@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michael Kerrisk <mtk.manpages@gmail.com>
Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
"Eric W . Biederman" <ebiederm@xmission.com>,
Dmitry Safonov <0x7f454c46@gmail.com>
Subject: Re: [PATCH v2] timens: show clock symbolic names in /proc/pid/timens_offsets
Date: Thu, 16 Apr 2020 11:52:29 +0200 [thread overview]
Message-ID: <87pnc7n4f6.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200416065648.GA801745@gmail.com>
Andrei Vagin <avagin@gmail.com> writes:
> On Sat, Apr 11, 2020 at 08:40:31AM -0700, Andrei Vagin wrote:
>> Michael Kerrisk suggested to replace numeric clock IDs on symbolic
>> names.
>>
>> Now the content of these files looks like this:
>> $ cat /proc/774/timens_offsets
>> monotonic 864000 0
>> boottime 1728000 0
>>
>> For setting offsets, both representations of clocks can be used.
>>
>> As for compatibility, it is acceptable to change things as long as
>> userspace doesn't care. The format of timens_offsets files is very
>> new and there are no userspace tools that rely on this format.
>>
>> But three projects crun, util-linux and criu rely on the interface of
>> setting time offsets and this is why we need to continue supporting the
>> clock IDs in this case.
>>
>> Fixes: 04a8682a71be ("fs/proc: Introduce /proc/pid/timens_offsets")
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Eric W. Biederman <ebiederm@xmission.com>
>> Cc: Dmitry Safonov <0x7f454c46@gmail.com>
>> Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
>
> Thomas and Andrew, could you merge this patch? I am sorry, I used the
> wrong subsystem prefix. Let me know if I need to send the third version
> of this patch.
Picking it up.
next prev parent reply other threads:[~2020-04-16 9:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 6:52 [PATCH] timens: show clock symbolic names in /proc/pid/timens_offsets Andrei Vagin
2020-04-11 10:32 ` Michael Kerrisk (man-pages)
2020-04-11 10:36 ` Michael Kerrisk (man-pages)
2020-04-11 15:40 ` [PATCH v2] " Andrei Vagin
2020-04-12 5:51 ` Michael Kerrisk (man-pages)
2020-04-13 22:47 ` Andrew Morton
2020-04-14 0:04 ` Andrei Vagin
2020-04-14 9:51 ` Michael Kerrisk (man-pages)
2020-04-16 6:56 ` Andrei Vagin
2020-04-16 7:10 ` Michael Kerrisk (man-pages)
2020-04-16 9:52 ` Thomas Gleixner [this message]
2020-04-16 10:15 ` [tip: timers/urgent] proc, time/namespace: Show " tip-bot2 for Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnc7n4f6.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).