From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Andrei Vagin <avagin@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: mtk.manpages@gmail.com, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Eric W . Biederman" <ebiederm@xmission.com>,
Dmitry Safonov <0x7f454c46@gmail.com>
Subject: Re: [PATCH] timens: show clock symbolic names in /proc/pid/timens_offsets
Date: Sat, 11 Apr 2020 12:36:32 +0200 [thread overview]
Message-ID: <96bedbaf-49ea-f24b-b7b1-fb9a57fb6c7d@gmail.com> (raw)
In-Reply-To: <afd9a489-bea7-c34c-14c2-405b536deb0d@gmail.com>
> As things stand, there is to my eye an excessive amount of white space
> in the output produced by this line:
>
>> + seq_printf(m, "%s\t%10lld\t%10ld\n", clock, ts->tv_sec, ts->tv_nsec);
>
> Can I suggest instead something like:
>
> seq_printf(m, "%-16s %10lld %9ld\n", clock, ts->tv_sec, ts->tv_nsec);
Actually, how about even s/-16s/-10s/ for that first field.
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2020-04-11 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 6:52 [PATCH] timens: show clock symbolic names in /proc/pid/timens_offsets Andrei Vagin
2020-04-11 10:32 ` Michael Kerrisk (man-pages)
2020-04-11 10:36 ` Michael Kerrisk (man-pages) [this message]
2020-04-11 15:40 ` [PATCH v2] " Andrei Vagin
2020-04-12 5:51 ` Michael Kerrisk (man-pages)
2020-04-13 22:47 ` Andrew Morton
2020-04-14 0:04 ` Andrei Vagin
2020-04-14 9:51 ` Michael Kerrisk (man-pages)
2020-04-16 6:56 ` Andrei Vagin
2020-04-16 7:10 ` Michael Kerrisk (man-pages)
2020-04-16 9:52 ` Thomas Gleixner
2020-04-16 10:15 ` [tip: timers/urgent] proc, time/namespace: Show " tip-bot2 for Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96bedbaf-49ea-f24b-b7b1-fb9a57fb6c7d@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).