[PATCH] tty/sysrq: Export sysrq_mask()

[PATCH] tty/sysrq: Export sysrq_mask()

[Dmitry Safonov]

Build fix for serial_core being module:
  ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
 drivers/tty/sysrq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 5e0d0813da55..a0760bcd7a97 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -74,6 +74,7 @@ int sysrq_mask(void)
 		return 1;
 	return sysrq_enabled;
 }
+EXPORT_SYMBOL_GPL(sysrq_mask);
 
 /*
  * A value of 1 means 'all', other nonzero values are an op mask:
-- 
2.25.1

Re: [PATCH] tty/sysrq: Export sysrq_mask()

[Greg Kroah-Hartman]

On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
> Build fix for serial_core being module:
>   ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Dmitry Safonov <dima@arista.com>
> ---
>  drivers/tty/sysrq.c | 1 +
>  1 file changed, 1 insertion(+)

Is this a new problem?  What commit does this fix?

thanks,

greg k-h

Re: [PATCH] tty/sysrq: Export sysrq_mask()

[Dmitry Safonov]

On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
> On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
>> Build fix for serial_core being module:
>>   ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
>>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Jiri Slaby <jslaby@suse.com>
>> Reported-by: "kernelci.org bot" <bot@kernelci.org>
>> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Dmitry Safonov <dima@arista.com>
>> ---
>>  drivers/tty/sysrq.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Is this a new problem?  What commit does this fix?

Right, sorry I've managed to forget adding the tag:

Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")

Maybe also:

Link:
https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/

Thanks,
          Dmitry

Re: [PATCH] tty/sysrq: Export sysrq_mask()

[Greg Kroah-Hartman]

On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
> >> Build fix for serial_core being module:
> >>   ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
> >>
> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Cc: Jiri Slaby <jslaby@suse.com>
> >> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> >> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> >> Signed-off-by: Dmitry Safonov <dima@arista.com>
> >> ---
> >>  drivers/tty/sysrq.c | 1 +
> >>  1 file changed, 1 insertion(+)
> > 
> > Is this a new problem?  What commit does this fix?
> 
> Right, sorry I've managed to forget adding the tag:
> 
> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
> 
> Maybe also:
> 
> Link:
> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/

Thanks, that works.  WIll queue this up after -rc1 is out.

greg k-h

Re: [PATCH] tty/sysrq: Export sysrq_mask()

[Michael Ellerman]

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
>> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
>> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
>> >> Build fix for serial_core being module:
>> >>   ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
>> >>
>> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> >> Cc: Jiri Slaby <jslaby@suse.com>
>> >> Reported-by: "kernelci.org bot" <bot@kernelci.org>
>> >> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>> >> Signed-off-by: Dmitry Safonov <dima@arista.com>
>> >> ---
>> >>  drivers/tty/sysrq.c | 1 +
>> >>  1 file changed, 1 insertion(+)
>> > 
>> > Is this a new problem?  What commit does this fix?
>> 
>> Right, sorry I've managed to forget adding the tag:
>> 
>> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
>> 
>> Maybe also:
>> 
>> Link:
>> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/
>
> Thanks, that works.  WIll queue this up after -rc1 is out.

Why wait until after rc1?

It's a build break for a bunch of folks and the fix is obviously correct
(famous last words).

cheers

Re: [PATCH] tty/sysrq: Export sysrq_mask()

[Dave Airlie]

On Thu, 2 Apr 2020 at 11:46, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> > On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
> >> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
> >> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
> >> >> Build fix for serial_core being module:
> >> >>   ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
> >> >>
> >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> >> Cc: Jiri Slaby <jslaby@suse.com>
> >> >> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> >> >> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> >> >> Signed-off-by: Dmitry Safonov <dima@arista.com>
> >> >> ---
> >> >>  drivers/tty/sysrq.c | 1 +
> >> >>  1 file changed, 1 insertion(+)
> >> >
> >> > Is this a new problem?  What commit does this fix?
> >>
> >> Right, sorry I've managed to forget adding the tag:
> >>
> >> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
> >>
> >> Maybe also:
> >>
> >> Link:
> >> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/
> >
> > Thanks, that works.  WIll queue this up after -rc1 is out.
>
> Why wait until after rc1?
>
> It's a build break for a bunch of folks and the fix is obviously correct
> (famous last words).

definitely seems like something that should be fixed prior to rc1,
s390 builds in fedora are hitting it.

Dave.

Re: [PATCH] tty/sysrq: Export sysrq_mask()

[Greg Kroah-Hartman]

On Sat, Apr 04, 2020 at 07:53:10AM +1000, Dave Airlie wrote:
> On Thu, 2 Apr 2020 at 11:46, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> > > On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
> > >> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
> > >> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
> > >> >> Build fix for serial_core being module:
> > >> >>   ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
> > >> >>
> > >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >> >> Cc: Jiri Slaby <jslaby@suse.com>
> > >> >> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> > >> >> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> > >> >> Signed-off-by: Dmitry Safonov <dima@arista.com>
> > >> >> ---
> > >> >>  drivers/tty/sysrq.c | 1 +
> > >> >>  1 file changed, 1 insertion(+)
> > >> >
> > >> > Is this a new problem?  What commit does this fix?
> > >>
> > >> Right, sorry I've managed to forget adding the tag:
> > >>
> > >> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
> > >>
> > >> Maybe also:
> > >>
> > >> Link:
> > >> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/
> > >
> > > Thanks, that works.  WIll queue this up after -rc1 is out.
> >
> > Why wait until after rc1?
> >
> > It's a build break for a bunch of folks and the fix is obviously correct
> > (famous last words).
> 
> definitely seems like something that should be fixed prior to rc1,
> s390 builds in fedora are hitting it.

Ugh, I missed this, I'll go queue this up now, sorry for the delay...

greg k-h