* [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607
@ 2019-02-15 12:20 Beniamino Galvani
2019-02-15 12:32 ` Bjørn Mork
2019-02-17 23:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Beniamino Galvani @ 2019-02-15 12:20 UTC (permalink / raw)
To: Bjørn Mork, David S . Miller, netdev, linux-usb, linux-kernel
The 1199:68C0 USB ID is reused by Sierra WP7607 which requires the DTR
quirk to be detected. Apply QMI_QUIRK_SET_DTR unconditionally as
already done for other IDs shared between different devices.
Signed-off-by: Beniamino Galvani <bgalvani@redhat.com>
---
drivers/net/usb/qmi_wwan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 735ad838e2ba..18af2f8eee96 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1201,8 +1201,8 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x114f, 0x68a2, 8)}, /* Sierra Wireless MC7750 */
{QMI_FIXED_INTF(0x1199, 0x68a2, 8)}, /* Sierra Wireless MC7710 in QMI mode */
{QMI_FIXED_INTF(0x1199, 0x68a2, 19)}, /* Sierra Wireless MC7710 in QMI mode */
- {QMI_FIXED_INTF(0x1199, 0x68c0, 8)}, /* Sierra Wireless MC7304/MC7354 */
- {QMI_FIXED_INTF(0x1199, 0x68c0, 10)}, /* Sierra Wireless MC7304/MC7354 */
+ {QMI_QUIRK_SET_DTR(0x1199, 0x68c0, 8)}, /* Sierra Wireless MC7304/MC7354, WP76xx */
+ {QMI_QUIRK_SET_DTR(0x1199, 0x68c0, 10)},/* Sierra Wireless MC7304/MC7354 */
{QMI_FIXED_INTF(0x1199, 0x901c, 8)}, /* Sierra Wireless EM7700 */
{QMI_FIXED_INTF(0x1199, 0x901f, 8)}, /* Sierra Wireless EM7355 */
{QMI_FIXED_INTF(0x1199, 0x9041, 8)}, /* Sierra Wireless MC7305/MC7355 */
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607
2019-02-15 12:20 [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607 Beniamino Galvani
@ 2019-02-15 12:32 ` Bjørn Mork
2019-02-17 23:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Bjørn Mork @ 2019-02-15 12:32 UTC (permalink / raw)
To: Beniamino Galvani; +Cc: David S . Miller, netdev, linux-usb, linux-kernel
Beniamino Galvani <bgalvani@redhat.com> writes:
> The 1199:68C0 USB ID is reused by Sierra WP7607 which requires the DTR
> quirk to be detected. Apply QMI_QUIRK_SET_DTR unconditionally as
> already done for other IDs shared between different devices.
>
> Signed-off-by: Beniamino Galvani <bgalvani@redhat.com>
Thanks. Looks like it's time to consider applying this unconditionally
to all devices. Feel free to propose something like that the next time
this issue comes up.
Acked-by: Bjørn Mork <bjorn@mork.no>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607
2019-02-15 12:20 [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607 Beniamino Galvani
2019-02-15 12:32 ` Bjørn Mork
@ 2019-02-17 23:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-02-17 23:41 UTC (permalink / raw)
To: bgalvani; +Cc: bjorn, netdev, linux-usb, linux-kernel
From: Beniamino Galvani <bgalvani@redhat.com>
Date: Fri, 15 Feb 2019 13:20:42 +0100
> The 1199:68C0 USB ID is reused by Sierra WP7607 which requires the DTR
> quirk to be detected. Apply QMI_QUIRK_SET_DTR unconditionally as
> already done for other IDs shared between different devices.
>
> Signed-off-by: Beniamino Galvani <bgalvani@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-17 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-15 12:20 [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607 Beniamino Galvani
2019-02-15 12:32 ` Bjørn Mork
2019-02-17 23:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).