Re: [RFC PATCH v2 07/15] usb:cdns3: Adds Device mode support - initialization.

From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>,
	Pawel Laszczak <pawell@cadence.com>,
	devicetree@vger.kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, adouglas@cadence.com,
	jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com,
	sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com,
	kurahul@cadence.com
Subject: Re: [RFC PATCH v2 07/15] usb:cdns3: Adds Device mode support - initialization.
Date: Wed, 28 Nov 2018 13:40:34 +0200	[thread overview]
Message-ID: <87pnupzaz1.fsf@linux.intel.com> (raw)
In-Reply-To: <5BFE7D2E.7030702@ti.com>

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

Hi,

Roger Quadros <rogerq@ti.com> writes:
>> +static void cdns3_gadget_config(struct cdns3_device *priv_dev)
>> +{
>> +	struct cdns3_usb_regs __iomem *regs = priv_dev->regs;
>> +
>> +	cdns3_ep0_config(priv_dev);
>> +
>> +	/* enable interrupts for endpoint 0 (in and out) */
>> +	writel(EP_IEN_EP_OUT0 | EP_IEN_EP_IN0, &regs->ep_ien);
>> +
>> +	/* enable generic interrupt*/
>> +	writel(USB_IEN_INIT, &regs->usb_ien);
>> +	writel(USB_CONF_CLK2OFFDS | USB_CONF_L1DS, &regs->usb_conf);
>> +	writel(USB_CONF_DMULT, &regs->usb_conf);
>> +	writel(USB_CONF_DEVEN, &regs->usb_conf);
>
> If you are enabling interrupts in this patch you should handle them in the ISR.

Frankly, I don't understand why this is a series. It's a single driver
and splitting it into a series just makes it more difficult to review,
actually.

Sure, a single patch will be large, but there's no way to have a
functional driver until all patches are applied, anyway.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]