* [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init()
@ 2016-01-23 19:25 Masahiro Yamada
2016-01-23 22:15 ` Robert Jarzmik
2016-01-27 12:33 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2016-01-23 19:25 UTC (permalink / raw)
To: linux-gpio
Cc: Masahiro Yamada, Robert Jarzmik, Haojian Zhuang, Linus Walleij,
linux-kernel, Daniel Mack, linux-arm-kernel
Building pinctrl-pxa27x.c as a module causes a link error:
ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/pinctrl/pxa/pinctrl-pxa2xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
index d90e205..216f227 100644
--- a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
+++ b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
@@ -426,6 +426,7 @@ int pxa2xx_pinctrl_init(struct platform_device *pdev,
return 0;
}
+EXPORT_SYMBOL(pxa2xx_pinctrl_init);
int pxa2xx_pinctrl_exit(struct platform_device *pdev)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init()
2016-01-23 19:25 [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init() Masahiro Yamada
@ 2016-01-23 22:15 ` Robert Jarzmik
2016-01-27 12:33 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Robert Jarzmik @ 2016-01-23 22:15 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-gpio, Haojian Zhuang, Linus Walleij, linux-kernel,
Daniel Mack, linux-arm-kernel
Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> Building pinctrl-pxa27x.c as a module causes a link error:
>
> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Yeah, I see no other way out to spare namespace polution.
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init()
2016-01-23 19:25 [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init() Masahiro Yamada
2016-01-23 22:15 ` Robert Jarzmik
@ 2016-01-27 12:33 ` Linus Walleij
2016-01-27 20:20 ` Robert Jarzmik
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2016-01-27 12:33 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-gpio, Robert Jarzmik, Haojian Zhuang, linux-kernel,
Daniel Mack, linux-arm-kernel
On Sat, Jan 23, 2016 at 8:25 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Building pinctrl-pxa27x.c as a module causes a link error:
>
> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Patch applied with Robert's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init()
2016-01-27 12:33 ` Linus Walleij
@ 2016-01-27 20:20 ` Robert Jarzmik
0 siblings, 0 replies; 4+ messages in thread
From: Robert Jarzmik @ 2016-01-27 20:20 UTC (permalink / raw)
To: Linus Walleij
Cc: Masahiro Yamada, linux-gpio, Haojian Zhuang, linux-kernel,
Daniel Mack, linux-arm-kernel
Linus Walleij <linus.walleij@linaro.org> writes:
> On Sat, Jan 23, 2016 at 8:25 PM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>
>> Building pinctrl-pxa27x.c as a module causes a link error:
>>
>> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Patch applied with Robert's ACK.
Thanks Linus.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-27 20:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-23 19:25 [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init() Masahiro Yamada
2016-01-23 22:15 ` Robert Jarzmik
2016-01-27 12:33 ` Linus Walleij
2016-01-27 20:20 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).